* [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it
@ 2020-01-19 3:52 Simon Fong
2020-01-19 5:32 ` Joe Perches
2020-01-19 12:50 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Simon Fong @ 2020-01-19 3:52 UTC (permalink / raw)
To: abbotti; +Cc: hsweeten, gregkh, colin.king, devel, linux-kernel, Simon Fong
Clean up long line and align it
Signed-off-by: Simon Fong <simon.fongnt@gmail.com>
---
drivers/staging/comedi/drivers/usbdux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index 0350f303d557..b9c0b1a1d86e 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -204,7 +204,8 @@ struct usbdux_private {
struct mutex mut;
};
-static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
+static void usbdux_unlink_urbs(struct urb **urbs,
+ int num_urbs)
{
int i;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it
2020-01-19 3:52 [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it Simon Fong
@ 2020-01-19 5:32 ` Joe Perches
2020-01-19 12:50 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2020-01-19 5:32 UTC (permalink / raw)
To: Simon Fong, abbotti; +Cc: hsweeten, gregkh, colin.king, devel, linux-kernel
On Sun, 2020-01-19 at 11:52 +0800, Simon Fong wrote:
> Clean up long line and align it
[]
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
[]
> @@ -204,7 +204,8 @@ struct usbdux_private {
> struct mutex mut;
> };
>
> -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
Why do you believe this to be a long line?
It's only 63 characters.
1 2 3 4 5 6 7
1234567890123456789012345678901234567890123456789012345678901234567890
static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
> +static void usbdux_unlink_urbs(struct urb **urbs,
> + int num_urbs)
> {
> int i;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it
2020-01-19 3:52 [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it Simon Fong
2020-01-19 5:32 ` Joe Perches
@ 2020-01-19 12:50 ` Greg KH
2020-01-19 12:52 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-01-19 12:50 UTC (permalink / raw)
To: Simon Fong; +Cc: abbotti, devel, linux-kernel, colin.king
On Sun, Jan 19, 2020 at 11:52:43AM +0800, Simon Fong wrote:
> Clean up long line and align it
>
> Signed-off-by: Simon Fong <simon.fongnt@gmail.com>
> ---
> drivers/staging/comedi/drivers/usbdux.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index 0350f303d557..b9c0b1a1d86e 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -204,7 +204,8 @@ struct usbdux_private {
> struct mutex mut;
> };
>
> -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
> +static void usbdux_unlink_urbs(struct urb **urbs,
> + int num_urbs)
As Joe said, there is no reason to change this line that I can see, why
do you want to do that?
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it
2020-01-19 12:50 ` Greg KH
@ 2020-01-19 12:52 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-01-19 12:52 UTC (permalink / raw)
To: Simon Fong; +Cc: abbotti, devel, linux-kernel, colin.king
On Sun, Jan 19, 2020 at 01:50:24PM +0100, Greg KH wrote:
> On Sun, Jan 19, 2020 at 11:52:43AM +0800, Simon Fong wrote:
> > Clean up long line and align it
> >
> > Signed-off-by: Simon Fong <simon.fongnt@gmail.com>
> > ---
> > drivers/staging/comedi/drivers/usbdux.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> > index 0350f303d557..b9c0b1a1d86e 100644
> > --- a/drivers/staging/comedi/drivers/usbdux.c
> > +++ b/drivers/staging/comedi/drivers/usbdux.c
> > @@ -204,7 +204,8 @@ struct usbdux_private {
> > struct mutex mut;
> > };
> >
> > -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs)
> > +static void usbdux_unlink_urbs(struct urb **urbs,
> > + int num_urbs)
>
> As Joe said, there is no reason to change this line that I can see, why
> do you want to do that?
Also, where are patches 1 and 2 of this 3 patch series?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-19 12:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-19 3:52 [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it Simon Fong
2020-01-19 5:32 ` Joe Perches
2020-01-19 12:50 ` Greg KH
2020-01-19 12:52 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox