From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3558C33CA1 for ; Mon, 20 Jan 2020 09:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A57A6207FF for ; Mon, 20 Jan 2020 09:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iv0Z32gf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgATJZf (ORCPT ); Mon, 20 Jan 2020 04:25:35 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:30314 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725872AbgATJZf (ORCPT ); Mon, 20 Jan 2020 04:25:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579512334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lOIObIVQPcG0P2nZxFamtw5erOeaKTYFa6Quj1aWKjM=; b=iv0Z32gfnFgxwJwHQeTxWt9dYEO07kRFzAy/8X1iYpcJXu1KlNvAWGfFeGiGt77Eps2bAU RxbqRQj+V8C61L89DAB25wwTPI2KCbfppGMdIJOWsCjr+w7EHvW7jCWmE4ZxEtiMtOcBcD 6BBoZlqAXE3Vv6WzDdz4qLhJ+dpnmso= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-B7425tUUNM2PowXDVNkNuA-1; Mon, 20 Jan 2020 04:25:31 -0500 X-MC-Unique: B7425tUUNM2PowXDVNkNuA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76D5F800D4C; Mon, 20 Jan 2020 09:25:29 +0000 (UTC) Received: from krava (unknown [10.43.17.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C2AF1C94F; Mon, 20 Jan 2020 09:25:26 +0000 (UTC) Date: Mon, 20 Jan 2020 10:25:25 +0100 From: Jiri Olsa To: kajoljain Cc: "Jin, Yao" , acme@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Alexander Shishkin , Andi Kleen , Jiri Olsa , Kan Liang , Peter Zijlstra , Madhavan Srinivasan , Anju T Sudhakar , Ravi Bangoria Subject: Re: [PATCH] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events Message-ID: <20200120092525.GB608405@krava> References: <20200108065844.4030-1-kjain@linux.ibm.com> <822bcb9d-4c08-39c5-e6e7-9c3e20d77852@linux.ibm.com> <20200108160249.GD402774@krava> <20200120092352.GA608405@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20200120092352.GA608405@krava> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2020 at 10:23:56AM +0100, Jiri Olsa wrote: > On Mon, Jan 20, 2020 at 02:23:19PM +0530, kajoljain wrote: > >=20 > > On 1/8/20 9:32 PM, Jiri Olsa wrote: > > > On Wed, Jan 08, 2020 at 02:41:35PM +0530, kajoljain wrote: > > >=20 > > > SNIP > > >=20 > > > > > > -=A0=A0=A0 int i =3D 0; > > > > > > +=A0=A0=A0 int i =3D 0, j =3D 0; > > > > > > =A0=A0=A0=A0=A0 bool leader_found; > > > > > > =A0 =A0=A0=A0=A0=A0 evlist__for_each_entry (perf_evlist, ev)= { > > > > > > +=A0=A0=A0=A0=A0=A0=A0 j++; > > > > > > +=A0=A0=A0=A0=A0=A0=A0 if (j <=3D iterator_perf_evlist) > > > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 continue; > > > > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 if (!strcmp(ev->name, ids[i])) { > > > > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (!metric_events[i= ]) > > > > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 metric_e= vents[i] =3D ev; > > > > > > @@ -146,6 +151,7 @@ static struct evsel *find_evsel_group(str= uct > > > > > > evlist *perf_evlist, > > > > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 } > > > > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 } > > > > > > =A0=A0=A0=A0=A0 } > > > > > > +=A0=A0=A0 iterator_perf_evlist =3D j; > > > > > > =A0 =A0=A0=A0=A0=A0 return metric_events[0]; > > > > > > =A0 } > > > > > >=20 > > > > > Thanks for reporting and fixing this issue. > > > > >=20 > > > > > I just have one question, do we really need a *static variable*= to track > > > > > the matched events? Perhaps using an input parameter? > > > > Hi Jin, > > > >=20 > > > > The other way I come up with to solve this issue is, making chang= e in > > > > perf_evlist itself by adding some flag in event name, to keep tra= ck of > > > > matched events. > > > >=20 > > > > As if we change event name itself, next time when we compare it w= on't > > > > matched. But in that case we need to remove those flag later. Whi= ch will > > > > increase the > > > >=20 > > > > complexity. If you have any suggestions, please let me know. > > > we already keep evsel::cpu_iter for similar concept > > >=20 > > > so I guess we could have some iterator_perf_evlist variable in evli= st.. > > > that is if we don't find other solution (other than static varable) > >=20 > > Hi Jiri, > >=20 > > =A0=A0=A0=A0=A0=A0=A0=A0 Thanks for reviewing the patch. I checked 'e= vsel::cpu_iter' > > variable, I think it added recently and I am not able to find any sim= ilar > > kind of variable in > >=20 > > =A0=A0=A0 =A0=A0=A0=A0 evlist. Please let me know if my understanding= is fine. Do you want > > me to add new variable in evlist itself or there is any other way pos= sible. ah sry, it's in 'struct evsel' ;-) jirka >=20 > please check Arnaldo's tree: > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/cor= e >=20 > jirka