From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4 3/4] perf util: Flexible to set block info output formats
Date: Mon, 20 Jan 2020 10:47:37 +0100 [thread overview]
Message-ID: <20200120094737.GF608405@krava> (raw)
In-Reply-To: <20200115192904.16798-3-yao.jin@linux.intel.com>
On Thu, Jan 16, 2020 at 03:29:03AM +0800, Jin Yao wrote:
SNIP
> + block_hpps, nr_hpps);
>
> - perf_hpp_list__register_sort_field(&bh->block_list,
> - &block_fmts[PERF_HPP_REPORT__BLOCK_TOTAL_CYCLES_PCT].fmt);
> + /* Sort by the first fmt */
> + perf_hpp_list__register_sort_field(&bh->block_list, &block_fmts[0].fmt);
> }
>
> -static void process_block_report(struct hists *hists,
> - struct block_report *block_report,
> - u64 total_cycles)
> +static int process_block_report(struct hists *hists,
> + struct block_report *block_report,
> + u64 total_cycles, int *block_hpps,
> + int nr_hpps)
> {
> struct rb_node *next = rb_first_cached(&hists->entries);
> struct block_hist *bh = &block_report->hist;
> struct hist_entry *he;
>
> - init_block_hist(bh, block_report->fmts);
> + if (nr_hpps > PERF_HPP_REPORT__BLOCK_MAX_INDEX)
hum, should be '>=' above.. ?
jirka
next prev parent reply other threads:[~2020-01-20 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 19:29 [PATCH v4 1/4] perf util: Move block_pair_cmp to block-info Jin Yao
2020-01-15 19:29 ` [PATCH v4 2/4] perf util: Validate map/dso/sym before comparing blocks Jin Yao
2020-01-15 19:29 ` [PATCH v4 3/4] perf util: Flexible to set block info output formats Jin Yao
2020-01-20 9:47 ` Jiri Olsa
2020-01-20 14:50 ` Jin, Yao
2020-01-20 9:47 ` Jiri Olsa [this message]
2020-01-20 15:00 ` Jin, Yao
2020-01-27 12:31 ` Jin, Yao
2020-01-28 9:21 ` Jiri Olsa
2020-01-28 10:27 ` Jin, Yao
2020-01-15 19:29 ` [PATCH v4 4/4] perf util: Support color ops to print block percents in color Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120094737.GF608405@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox