From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC914C33CAA for ; Mon, 20 Jan 2020 11:13:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF37221569 for ; Mon, 20 Jan 2020 11:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UXD+EDxF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbgATLM7 (ORCPT ); Mon, 20 Jan 2020 06:12:59 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44139 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbgATLM7 (ORCPT ); Mon, 20 Jan 2020 06:12:59 -0500 Received: by mail-wr1-f67.google.com with SMTP id q10so29098199wrm.11 for ; Mon, 20 Jan 2020 03:12:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HlltTZpAEDLvscRb688hqMcZim5skpAdya8N3DvxZEM=; b=UXD+EDxFhXSrpENIh2A/85v6fyes50rL1DiydfBrrvhrh6DNi9F+AYVNeheFVXBxCJ rGaRLMVLeDk7c9vYNEQ6xdXdgeJPqbLah7k34UX9s6IFGZTDtVmaTFFdMbqTrDW5LNCM hU19egfqAtCu6kYb2IvHL2KT8v7Gn612jjhrAVh5NxbkhO46gNGG2Z5TKQvoi4yMZipc EK5jOZ8a2x12A0c27EKdljk+Ea/kU/GzLZdwxlC/FrBdhL1R/6pf86oBjHi7R4TngeEX Uh3A0Uceu9xjf7K1PCKrA8imYxWxO2zlRJKdJ/mc4TfYME1FKfO7F7AFWZZXSgDJa8W8 +Caw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HlltTZpAEDLvscRb688hqMcZim5skpAdya8N3DvxZEM=; b=IU19viE38m9WJQZFTYqefvRZpZE3cCSkXaTf9I6U0OCY0/CAWk5i46WG6jRnYq6UhP MPank+7Ib78zdreYCilTxS/D1LIWmqt/vkRVCe/9vNDz7kQqmHC8GVE8av1wUB7aAC5J gvUYFz+3GB7KSAs+eclTNnsmWzIQ9d069HxsUDrmZ9aYto/PPlWdybzT+ORt3daGxO2L E7BGS1lMzhrmtFk+nkOG6qeXU8CdqrPUqTMzOLap+IGZm49HYrlKHictuL7w7seY96bq hql5iR4wzXFFcDYkTPBoEbHr9N/Fu6KVvoYLczecG1SUY42Z9kdFnMEhGSjE9wK3IKYu vo4w== X-Gm-Message-State: APjAAAUMYVm3gPqq4XkDZr3J4THvuf/QrDk7FQVRuaz/1nyDSOYl+LTf tXkfnUIqgVP5KFjUnTq1+vTkQw== X-Google-Smtp-Source: APXvYqxQHGbEwEkD/O3AcaNIUudE99Tt5DRIuc3ysO5EJhjUT1/um+Fyx5PMGE3tKu56OqMRzGjN5A== X-Received: by 2002:a5d:480f:: with SMTP id l15mr17182858wrq.305.1579518777252; Mon, 20 Jan 2020 03:12:57 -0800 (PST) Received: from dell ([2.27.35.227]) by smtp.gmail.com with ESMTPSA id g9sm47501170wro.67.2020.01.20.03.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 03:12:56 -0800 (PST) Date: Mon, 20 Jan 2020 11:13:12 +0000 From: Lee Jones To: Mika Westerberg , Mark Brown Cc: Andy Shevchenko , Darren Hart , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 35/36] platform/x86: intel_pmc_ipc: Convert to MFD Message-ID: <20200120111312.GD15507@dell> References: <20200113135623.56286-1-mika.westerberg@linux.intel.com> <20200113135623.56286-36-mika.westerberg@linux.intel.com> <20200116132108.GH325@dell> <20200116143730.GE2838@lahna.fi.intel.com> <20200117113202.GH15507@dell> <20200120092650.GI2665@lahna.fi.intel.com> <20200120111159.GC15507@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200120111159.GC15507@dell> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Adding Mark (the Regmap Maintainer) to the conversation. Fingers faster than brain! I'll actually add him this time - sorry for the noise! > On Mon, 20 Jan 2020, Mika Westerberg wrote: > > On Fri, Jan 17, 2020 at 11:32:02AM +0000, Lee Jones wrote: > > > [...] > > > > > > > > Looks like Regmap could save you the trouble here. > > > > > > > > Agreed. > > > > > > Great. > > > > I started to implement regmap for this driver but I run into some > > problems. The registers we read/write are all 64-bit and accessed trough > > readq/writeq accessors. However, the regmap API takes unsigned int: > > > > int regmap_write(struct regmap *map, unsigned int reg, unsigned int val); > > int regmap_read(struct regmap *map, unsigned int reg, unsigned int *val); > > > > I'm not sure how we can take advantage of this API with the 64-bit > > registers. There are "raw" versions of the functions that take void > > pointer like: > > > > int regmap_raw_read(struct regmap *map, unsigned int reg, > > void *val, size_t val_len); > > > > but looking at the implementation if the register gets cached it > > internally does reads in unsigned int sized chunks (if I understand it > > right). > > > > Any ideas how this can be done? Mark, Does Regmap support 64bit accesses? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog