Re: [PATCH v2 9/9] ASoC: Intel: Switch DMI table match to a test of variable

Andy Shevchenko
2020-01-21T15:20:34Z

On Mon, Jan 20, 2020 at 05:55:54PM +0000, Mark Brown wrote:
> On Mon, Jan 20, 2020 at 06:08:01PM +0200, Andy Shevchenko wrote:
> > Since we have a common x86 quirk that provides an exported variable,
> > use it instead of local DMI table match.
>
> Acked-by: Mark Brown <broonie@kernel.org>
>
> > - if (cht_machine_id == CHT_SURFACE_MACH)
> > - return &cht_surface_mach;
> > - else
> > - return mach;
> > + return x86_microsoft_surface_3_machine ? &cht_surface_mach : arg;
>
> but if you're respinning this please replace this with a normal
> conditional statement to improve legibility.

Okay, will do. Thanks for review!

--
With Best Regards,
Andy Shevchenko