From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE7EC33CAA for ; Tue, 21 Jan 2020 09:38:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8553E217F4 for ; Tue, 21 Jan 2020 09:38:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="I4Il4xqb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729208AbgAUJiC (ORCPT ); Tue, 21 Jan 2020 04:38:02 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46821 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727962AbgAUJiC (ORCPT ); Tue, 21 Jan 2020 04:38:02 -0500 Received: by mail-wr1-f67.google.com with SMTP id z7so2289924wrl.13 for ; Tue, 21 Jan 2020 01:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=I4Il4xqb/mQRJaa0qSSl+Y25gZ18e057wP1tdP0lh2yLeaVpX0hadSOR4cl/LQpB3Q tyaDpcGYEDRokttwYZKiVcZfJVF8EHoSYV8AeT5Pk8Cx7E9Px1VKdhTcXR1aAUSJd42D xFOr6MeGSxv5TF/P/YEky3SS2IZFj68f7cxUiU1OZ4UxuYB744pGOuVT1Fv5ZBgPKRCQ 7lN+SeGd90TfRO9gjPQRhJKb/pkMVZLlA3k0gUeRo6+ZVDTta1IW1eGaQBVEL1GveVLC n0vz510kYT0OpN/IyanOQzCHQTHpjRTMgbVeaY/5N811ccD6PckCAVfLKOa3fN1tAM5n aJ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=axMqLRJnYpSfiu4kC6BnxENka1YcbBbouljpGodbNSSmOKGmWKCaWynWdqfrYqFLkP P9X2IQk/ySCVYTLSJImc2yVfr36O5lyAlCXZnfDaGbGCAR5E0Z7/jMjBSC7X14bvOWCp xkwrLRdsURanvg4lJkOCBocaq2074no1m1EIpG/X7O20zXxBIjlETxY5qw/kPjuSwxeQ V06PAx17VF7WU/YijYiGfsD1lPEjX3i62wQybTrzybHrkyF3HUdIrq0PKeJDhri7DM7x UFnSCFjpktJR2sU4pGLp+toXZw3TAgqB9dikuvgboa8EAVutcpYUItONis17jkEjm9sg D2pg== X-Gm-Message-State: APjAAAXvRYDODKys7Q0YdPCgX0i2REPO0Te6dytguvIPvpzEdcW9e8UE S7MOuWMguDpkuRNsgFu7vdnD9b1t4aeAI1nO X-Google-Smtp-Source: APXvYqzNPRBGH9fYa6XMUb9Kcbd+L9DaQWdS1c4YXNu4dlR3oazpTgiDZXxcGp6bVMzhgy2FLbeDYg== X-Received: by 2002:adf:dfc2:: with SMTP id q2mr4336811wrn.251.1579599479951; Tue, 21 Jan 2020 01:37:59 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id u22sm54210033wru.30.2020.01.21.01.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:37:59 -0800 (PST) Date: Tue, 21 Jan 2020 09:37:55 +0000 From: Quentin Perret To: Dietmar Eggemann Cc: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Chris.Redpath@arm.com, ionela.voinescu@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, kernel-team@android.com Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093755.GA157387@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote: > True. But then we hard-code that a CPU device performance domain can > only be a frequency domain (which is true today). > > The task scheduler (build_perf_domains()) and thermal are already using > cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework > would too for CPU devices. I assume that could work with a couple of > adaptations in Documentation/power/energy-model.rst. Agreed, and if one day we have a real use case where the pd mask and the cpufreq policy mask need to be different, we'll do the necessary changes. But until then I don't see a reason to object to Lukasz' proposal. So +1 from me. Thanks, Quentin