Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports

Robin Murphy
2020-01-21T14:57:02Z

On 21/01/2020 1:45 pm, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The lvds controller has two ports. port@0 for the connection
> to the display controller(s) and port@1 for the connection to
> the panel, so should have a ports node covering the port@x nodes.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 9b1c92132007..37e014444214 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -421,19 +421,24 @@ lvds: lvds {
> rockchip,output = "lvds";
> status = "disabled";

FWIW, the main node's "#{address,size}-cells" properties above here
should now be unnecessary too.

Robin.

>
> - port@0 {
> - reg = <0>;
> + ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - lvds_vopb_in: endpoint@0 {
> + port@0 {
> reg = <0>;
> - remote-endpoint = <&vopb_out_lvds>;
> - };
> -
> - lvds_vopl_in: endpoint@1 {
> - reg = <1>;
> - remote-endpoint = <&vopl_out_lvds>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + lvds_vopb_in: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&vopb_out_lvds>;
> + };
> +
> + lvds_vopl_in: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&vopl_out_lvds>;
> + };
> };
> };
> };
>