From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C803C2D0CE for ; Tue, 21 Jan 2020 15:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2770321569 for ; Tue, 21 Jan 2020 15:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729152AbgAUPUd (ORCPT ); Tue, 21 Jan 2020 10:20:33 -0500 Received: from mga01.intel.com ([192.55.52.88]:50929 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgAUPUc (ORCPT ); Tue, 21 Jan 2020 10:20:32 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 07:20:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,346,1574150400"; d="scan'208";a="259096316" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 21 Jan 2020 07:20:29 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1itvKQ-0007V5-FF; Tue, 21 Jan 2020 17:20:30 +0200 Date: Tue, 21 Jan 2020 17:20:30 +0200 From: Andy Shevchenko To: Mark Brown Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , alsa-devel@alsa-project.org Subject: Re: [PATCH v2 9/9] ASoC: Intel: Switch DMI table match to a test of variable Message-ID: <20200121152030.GU32742@smile.fi.intel.com> References: <20200120160801.53089-1-andriy.shevchenko@linux.intel.com> <20200120160801.53089-10-andriy.shevchenko@linux.intel.com> <20200120175554.GK6852@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120175554.GK6852@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2020 at 05:55:54PM +0000, Mark Brown wrote: > On Mon, Jan 20, 2020 at 06:08:01PM +0200, Andy Shevchenko wrote: > > Since we have a common x86 quirk that provides an exported variable, > > use it instead of local DMI table match. > > Acked-by: Mark Brown > > > - if (cht_machine_id == CHT_SURFACE_MACH) > > - return &cht_surface_mach; > > - else > > - return mach; > > + return x86_microsoft_surface_3_machine ? &cht_surface_mach : arg; > > but if you're respinning this please replace this with a normal > conditional statement to improve legibility. Okay, will do. Thanks for review! -- With Best Regards, Andy Shevchenko