Re: [PATCH v4 2/2] hwmon: (adt7475) Added attenuator bypass support

Guenter Roeck
2020-01-22T14:47:12Z

On 1/19/20 4:17 PM, Logan Shaw wrote:
> Added a new file documenting the adt7475 devicetree and added the four
> new properties to it.
>
> Signed-off-by: Logan Shaw <logan.shaw@alliedtelesis.co.nz>

Please fix the reported errors.

Guenter

> ---
> ---
> .../devicetree/bindings/hwmon/adt7475.yaml | 90 +++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> new file mode 100644
> index 000000000000..f2427de9991e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/adt7475.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADT7475 hwmon sensor
> +
> +maintainers:
> + - Jean Delvare <jdelvare@suse.com>
> +
> +description: |
> + The ADT7473, ADT7475, ADT7476, and ADT7490 are thermal monitors and multiple
> + PWN fan controllers.
> +
> + They support monitoring and controlling up to four fans (the ADT7490 can only
> + control up to three). They support reading a single on chip temperature
> + sensor and two off chip temperature sensors (the ADT7490 additionally
> + supports measuring up to three current external temperature sensors with
> + series resistance cancellation (SRC)).
> +
> + Datasheets:
> + https://www.onsemi.com/pub/Collateral/ADT7473-D.PDF
> + https://www.onsemi.com/pub/Collateral/ADT7475-D.PDF
> + https://www.onsemi.com/pub/Collateral/ADT7476-D.PDF
> + https://www.onsemi.com/pub/Collateral/ADT7490-D.PDF
> +
> + Description taken from omsemiconductors specification sheets, with minor
> + rephrasing.
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adt7473
> + - adi,adt7475
> + - adi,adt7476
> + - adi,adt7490
> +
> + reg:
> + maxItems: 1
> +
> + bypass-attenuator-in0:
> + description: |
> + Configures bypassing the individual voltage input
> + attenuator, on in0. This is supported on the ADT7476 and ADT7490.
> + If set to a non-zero integer the attenuator is bypassed, if set to
> + zero the attenuator is not bypassed. If the property is absent then
> + the config register is not modified.
> + maxItems: 1
> +
> + bypass-attenuator-in1:
> + description: |
> + Configures bypassing the individual voltage input
> + attenuator, on in1. This is supported on the ADT7473, ADT7475,
> + ADT7476 and ADT7490. If set to a non-zero integer the attenuator
> + is bypassed, if set to zero the attenuator is not bypassed. If the
> + property is absent then the config register is not modified.
> + maxItems: 1
> +
> + bypass-attenuator-in3:
> + description: |
> + Configures bypassing the individual voltage input
> + attenuator, on in3. This is supported on the ADT7476 and ADT7490.
> + If set to a non-zero integer the attenuator is bypassed, if set to
> + zero the attenuator is not bypassed. If the property is absent then
> + the config register is not modified.
> + maxItems: 1
> +
> + bypass-attenuator-in4:
> + description: |
> + Configures bypassing the individual voltage input
> + attenuator, on in4. This is supported on the ADT7476 and ADT7490.
> + If set to a non-zero integer the attenuator is bypassed, if set to
> + zero the attenuator is not bypassed. If the property is absent then
> + the config register is not modified.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + hwmon@2e {
> + compatible = "adi,adt7476";
> + reg = <0x2e>;
> + bypass-attenuator-in0 = <1>;
> + bypass-attenuator-in1 = <0>;
> + };
> +...
>