From: Greg KH <gregkh@linuxfoundation.org>
To: Valery Ivanov <ivalery111@gmail.com>
Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: fix missing a blank line after declaration
Date: Wed, 22 Jan 2020 09:44:36 +0100 [thread overview]
Message-ID: <20200122084436.GA2407794@kroah.com> (raw)
In-Reply-To: <20200119140359.GA8668@home>
On Sun, Jan 19, 2020 at 04:03:59PM +0200, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank lin after declarations"
> Issue found by checkpatch.pl
>
> Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
> ---
> drivers/staging/qlge/qlge_ethtool.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c
> index 56d116d79e56..2872b7120e36 100644
> --- a/drivers/staging/qlge/qlge_ethtool.c
> +++ b/drivers/staging/qlge/qlge_ethtool.c
> @@ -412,6 +412,7 @@ static void ql_get_drvinfo(struct net_device *ndev,
> struct ethtool_drvinfo *drvinfo)
> {
> struct ql_adapter *qdev = netdev_priv(ndev);
> +
> strlcpy(drvinfo->driver, qlge_driver_name, sizeof(drvinfo->driver));
> strlcpy(drvinfo->version, qlge_driver_version,
> sizeof(drvinfo->version));
> @@ -703,12 +704,14 @@ static int ql_set_pauseparam(struct net_device *netdev,
> static u32 ql_get_msglevel(struct net_device *ndev)
> {
> struct ql_adapter *qdev = netdev_priv(ndev);
> +
> return qdev->msg_enable;
> }
>
> static void ql_set_msglevel(struct net_device *ndev, u32 value)
> {
> struct ql_adapter *qdev = netdev_priv(ndev);
> +
> qdev->msg_enable = value;
> }
>
This fix is already in my tree, always be sure to work against
linux-next for new development so you do not duplicate existing work.
thanks,
greg k-h
prev parent reply other threads:[~2020-01-22 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 14:03 [PATCH] staging: qlge: fix missing a blank line after declaration Valery Ivanov
2020-01-22 8:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122084436.GA2407794@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=ivalery111@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox