From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Marco Elver <elver@google.com>, Qian Cai <cai@lca.pw>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] x86/mm/pat: silence a data race in cpa_4k_install
Date: Wed, 22 Jan 2020 09:46:04 +0100 [thread overview]
Message-ID: <20200122084604.GP14914@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200121154528.GK7808@zn.tnic>
On Tue, Jan 21, 2020 at 04:45:28PM +0100, Borislav Petkov wrote:
> On Tue, Jan 21, 2020 at 04:36:49PM +0100, Marco Elver wrote:
> > Isn't the intent "x86/mm/pat: Mark intentional data race" ? The fact
> > that KCSAN no longer shows the warning is a side-effect. At least
> > that's how I see it.
>
> Perhaps because you've been dealing with KCSAN for so long. :-)
>
> The main angle here, IMO, is that this "fix" is being done solely for
> KCSAN. Or is there another reason to "fix" intentional data races? At
> least I don't see one. And the text says
Documentation. It is a clear and concise marker of intent. Unintended
data races are bad.
Also, we've been adding annotations to the kernel source forever,
sparse, lockdep, etc.. now KCSAN. All we have to do is make sure they're
minimally invasive, and in that regard the date_race() marker is spot on
IMO.
next prev parent reply other threads:[~2020-01-22 8:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 15:15 [PATCH -next] x86/mm/pat: silence a data race in cpa_4k_install Qian Cai
2020-01-21 15:19 ` Marco Elver
2020-01-21 15:28 ` Borislav Petkov
2020-01-21 15:33 ` Qian Cai
2020-01-21 15:36 ` Marco Elver
2020-01-21 15:45 ` Borislav Petkov
2020-01-21 20:21 ` Qian Cai
2020-01-21 22:18 ` Borislav Petkov
2020-01-21 23:30 ` Marco Elver
2020-01-22 0:34 ` Qian Cai
2020-01-22 8:46 ` Peter Zijlstra [this message]
2020-01-23 2:15 ` Qian Cai
2020-01-23 8:16 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2020-01-21 15:50 Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122084604.GP14914@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=dave.hansen@linux.intel.com \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox