Re: [PATCH v3 0/9] x86: Easy way of detecting MS Surface 3

Andy Shevchenko
2020-02-14T14:24:52Z

On Wed, Jan 22, 2020 at 01:22:57PM +0200, Andy Shevchenko wrote:
> While working on RTC regression, I noticed that we are using the same DMI check
> over and over in the drivers for MS Surface 3 platform. This series dedicated
> for making it easier in the same way how it's done for Apple machines.

Any comments on this?

> Changelog v3:
> - fixed typo in patch 5 (Jonathan)
> - returned back to if {} else {} condition in ASoC driver (Mark)
> - added Mark's Ack tag
>
> Changelog v2:
> - removed RTC patches for now (the fix will be independent to this series)
> - added couple more clean ups to arch/x86/kernel/quirks.c
> - redone DMI quirk to use driver_data instead of callback
> - simplified check in soc-acpi-intel-cht-match.c to be oneliner
> - added a new patch to cover rt5645 codec driver
>
> Cc: Cezary Rojewski <cezary.rojewski@intel.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>
> Cc: Jie Yang <yang.jie@linux.intel.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
>
> Andy Shevchenko (9):
> x86/platform: Rename x86/apple.h -> x86/machine.h
> x86/quirks: Add missed include to satisfy static checker
> x86/quirks: Introduce hpet_dev_print_force_hpet_address() helper
> x86/quirks: Join string literals back
> x86/quirks: Convert DMI matching to use a table
> x86/quirks: Add a DMI quirk for Microsoft Surface 3
> platform/x86: surface3_wmi: Switch DMI table match to a test of
> variable
> ASoC: rt5645: Switch DMI table match to a test of variable
> ASoC: Intel: Switch DMI table match to a test of variable
>
> arch/x86/kernel/quirks.c | 91 +++++++++++++------
> drivers/platform/x86/surface3-wmi.c | 16 +---
> include/linux/platform_data/x86/apple.h | 14 +--
> include/linux/platform_data/x86/machine.h | 20 ++++
> sound/soc/codecs/rt5645.c | 14 ++-
> .../intel/common/soc-acpi-intel-cht-match.c | 28 +-----
> 6 files changed, 93 insertions(+), 90 deletions(-)
> create mode 100644 include/linux/platform_data/x86/machine.h
>
> --
> 2.24.1
>

--
With Best Regards,
Andy Shevchenko