Re: [PATCH v4 27/38] mfd: intel_soc_pmic_bxtwc: Convert to use new SCU IPC API

Mika Westerberg
2020-01-22T14:41:53Z

On Wed, Jan 22, 2020 at 02:46:21PM +0100, Greg Kroah-Hartman wrote:
> > if (ret) {
> > dev_err(pmic->dev, "Failed to read from PMIC\n");
>
> Meta-comment, the call should be the thing making that error message,
> do not force all callers to log it again, or in some other way. That
> just makes for a larger mess.

OK, I'll do that.