Re: [PATCH v4 37/38] platform/x86: intel_pmc_ipc: Convert to MFD

Mika Westerberg
2020-01-23T09:02:17Z

On Thu, Jan 23, 2020 at 08:01:42AM +0000, Lee Jones wrote:
> On Wed, 22 Jan 2020, Mika Westerberg wrote:
>
> > On Wed, Jan 22, 2020 at 01:27:57PM +0000, Lee Jones wrote:
> > > > Which type of device you suggest here? And which bus it should be
> > > > registered to? I think we can make this create a platform_device but
> > > > then we would need to do that from the PCI driver as well which seems
> > > > unnecessary since we already have the struct pci_dev.
> > >
> > > What kind of device is it?
> >
> > It is either part of an ACPI device (platform_device) or a PCI device
> > depending on the platform.
> >
> > > Refrain from using platform device, unless it is one please.
> >
> > OK.
> >
> > Greg suggested making the SCU IPC functionality a class and I think it
> > fits here nicely so I'm going to try that next if nobody objects. I'll
> > send the first cleanup patches separately.
>
> Sounds good.

FYI, I the cleanup patch series can be found here: