Re: [PATCH v4 11/38] platform/x86: intel_scu_ipc: Drop intel_scu_ipc_raw_command()

Mika Westerberg
2020-01-22T14:33:25Z

On Wed, Jan 22, 2020 at 02:36:19PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 21, 2020 at 07:00:47PM +0300, Mika Westerberg wrote:
> > There is no user for this function so we can drop it from the driver.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > arch/x86/include/asm/intel_scu_ipc.h | 2 -
> > drivers/platform/x86/intel_scu_ipc.c | 63 ----------------------------
> > 2 files changed, 65 deletions(-)
>
> These first 11 patches are fine, why didn't you just submit them as
> cleanups/fixes and then build on them with the rest? Having to wade
> through 38-patch series is a pain...

OK, I'll submit the first cleanup patches separately so they can be
applied first and then rework rest of the series on top.