From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>
Cc: dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drm/dp_mst: Mention max_payloads in proposed_vcpis/payloads docs
Date: Wed, 22 Jan 2020 21:57:29 +0200 [thread overview]
Message-ID: <20200122195729.GI13686@intel.com> (raw)
In-Reply-To: <20200122194321.14953-2-lyude@redhat.com>
On Wed, Jan 22, 2020 at 02:43:21PM -0500, Lyude Paul wrote:
> Mention that the size of these two structs is determined by
> max_payloads. Suggested by Ville Syrjälä.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> include/drm/drm_dp_mst_helper.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h
> index bcb39da9adb4..5483f888712a 100644
> --- a/include/drm/drm_dp_mst_helper.h
> +++ b/include/drm/drm_dp_mst_helper.h
> @@ -635,11 +635,13 @@ struct drm_dp_mst_topology_mgr {
> struct mutex payload_lock;
> /**
> * @proposed_vcpis: Array of pointers for the new VCPI allocation. The
> - * VCPI structure itself is &drm_dp_mst_port.vcpi.
> + * VCPI structure itself is &drm_dp_mst_port.vcpi, and the size of
> + * this array is determined by @max_payloads.
> */
> struct drm_dp_vcpi **proposed_vcpis;
> /**
> - * @payloads: Array of payloads.
> + * @payloads: Array of payloads. The size of this array is determined
> + * by @max_payloads.
> */
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> struct drm_dp_payload *payloads;
> /**
> --
> 2.24.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2020-01-22 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 19:43 [PATCH v2 1/2] drm/dp_mst: Fix clearing payload state on topology disable Lyude Paul
2020-01-22 19:43 ` [PATCH v2 2/2] drm/dp_mst: Mention max_payloads in proposed_vcpis/payloads docs Lyude Paul
2020-01-22 19:57 ` Ville Syrjälä [this message]
2020-01-22 20:51 ` [PATCH v2 1/2] drm/dp_mst: Fix clearing payload state on topology disable Ville Syrjälä
2020-01-22 23:43 ` Lyude Paul
2020-01-23 0:34 ` Lin, Wayne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122195729.GI13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox