From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F78C32771 for ; Thu, 23 Jan 2020 02:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 343D924676 for ; Thu, 23 Jan 2020 02:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579745630; bh=UVtHGuBwD4NKnOj+Kfsya+kpYb2Ei7ghhepkkktbhCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gcdROK1y8SzBtMdziJOygV46sweTD2vnYXuFybH8V54+1y7tHBP+LlOrRO5/v2cZo QtZbY94YD6iPEklBt1y9ncB7/EjCfijQgWAG3iSRgJrSrpbcbPKzn/X0dgSVSmTUuD 1AjW18IMxACPDY8E0Cb/YbWeVtWn0P6KprOgvuRs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgAWCNt (ORCPT ); Wed, 22 Jan 2020 21:13:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:44922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgAWCNs (ORCPT ); Wed, 22 Jan 2020 21:13:48 -0500 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CEFE24125; Thu, 23 Jan 2020 02:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579745628; bh=UVtHGuBwD4NKnOj+Kfsya+kpYb2Ei7ghhepkkktbhCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bDZDIFzZTL682ulrwViKOe3ewyQMdqkVmdmvds4xrpPq8JiU9RfR7qcpjFRab+o8R PiUYSZiGGtYjMeFGuBcGEK/Qsg/TCaVD+tNFJWPm5ZNhjNF2928EPwaguDVdEh+cr6 6tmFC6YDE4ITDDWouK47F3UXSqAHzvvr2BLnLGfM= Date: Wed, 22 Jan 2020 18:13:46 -0800 From: Eric Biggers To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Hridya Valsaraju Subject: Re: [PATCH 2/2] f2fs: Add f2fs stats to sysfs Message-ID: <20200123021346.GA862@sol.localdomain> References: <20200123011354.75282-1-jaegeuk@kernel.org> <20200123011354.75282-2-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123011354.75282-2-jaegeuk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 22, 2020 at 05:13:54PM -0800, Jaegeuk Kim wrote: > diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c > index ce2936554ef8..7565ba9967dd 100644 > --- a/fs/f2fs/debug.c > +++ b/fs/f2fs/debug.c > @@ -150,7 +150,7 @@ static void update_general_status(struct f2fs_sb_info *sbi) > /* > * This function calculates BDF of every segments > */ > -static void update_sit_info(struct f2fs_sb_info *sbi) > +void update_sit_info(struct f2fs_sb_info *sbi) > { > struct f2fs_stat_info *si = F2FS_STAT(sbi); > unsigned long long blks_per_sec, hblks_per_sec, total_vblocks; Global functions need a "f2fs_" prefix. - Eric