From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F26DC33CAA for ; Thu, 23 Jan 2020 08:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 470A02467B for ; Thu, 23 Jan 2020 08:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579769103; bh=WGwiLbw2RYeEBF4QqvP2f4Ql8aF8IMEbAzwfkCSdVNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1C6RQs96+fCeWNgNJrxNmRtB27ZdbUt/QuBZLJ4Iy1fGhzXNCPl5/lpNYLPoSNL9J dR1KbbEhKRsSNAjF4qlznXC/xIzJ1CXng3C9eLzFBYgXy/uwbgBKKaZDb4dbP0T+Gc v5h5Lq+GKa43FzUYtxTDSHfqPRkljUZsJnZ6WKno= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728609AbgAWIpC (ORCPT ); Thu, 23 Jan 2020 03:45:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:55262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbgAWIpC (ORCPT ); Thu, 23 Jan 2020 03:45:02 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4883C2073A; Thu, 23 Jan 2020 08:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579769101; bh=WGwiLbw2RYeEBF4QqvP2f4Ql8aF8IMEbAzwfkCSdVNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hx5NbUOphlTzFbzH/H3hS9BXrleVrdJQsHQ/lsEJiJX3HegGPHrhR7oTRh9iFo6Oi COXZ00HEFJooejGvMOEjIx+NTnqA3uQguK4Rva3cqt8B7y9BXPe5L2l4bQ+ZqjlZt0 GqneE37efKf36SkZ3WPk/RnuIy7Iv75BvJJ6c348= Date: Thu, 23 Jan 2020 09:44:59 +0100 From: Greg Kroah-Hartman To: Tetsuhiro Kohada Cc: Valdis Kletnieks , linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Mori.Takahiro@ab.mitsubishielectric.co.jp, motai.hirotaka@aj.mitsubishielectric.co.jp Subject: Re: [PATCH v2] staging: exfat: remove fs_func struct. Message-ID: <20200123084459.GA434861@kroah.com> References: <20200123083258.118854-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123083258.118854-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2020 at 05:32:58PM +0900, Tetsuhiro Kohada wrote: > From: "Tetsuhiro Kohada" > > Remove 'fs_func struct' and change indirect calls to direct calls. > > The following issues are described in exfat's TODO. > > Create helper function for exfat_set_entry_time () and > > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through the fs_func struc ponters ... > > The fs_func struct was used for switching the helper functions of fat16/fat32/exfat. > Now, it has lost the role of switching, just making the code less readable. > > Signed-off-by: Tetsuhiro Kohada > --- > drivers/staging/exfat/exfat.h | 79 +++++----- > drivers/staging/exfat/exfat_core.c | 214 +++++++++++----------------- > drivers/staging/exfat/exfat_super.c | 119 ++++++++-------- > 3 files changed, 178 insertions(+), 234 deletions(-) What changed from v1? Always put that below the --- line, as the documentation asks you to, so that we know what is happening here. Please fix that up and send a v3. thanks, greg k-h