Re: [PATCH v2 4/7] perf tools: Support "branch-misses:pp" on arm64

Jiri Olsa
2020-01-27T12:31:34Z

On Thu, Jan 23, 2020 at 04:07:31PM +0000, James Clark wrote:

SNIP

> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 1548237b6558..b9c7e5271611 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -9,6 +9,7 @@
> #include <errno.h>
> #include <inttypes.h>
> #include <poll.h>
> +#include "arm-spe.h"
> #include "cpumap.h"
> #include "util/mmap.h"
> #include "thread_map.h"
> @@ -179,6 +180,7 @@ void perf_evlist__splice_list_tail(struct evlist *evlist,
> struct evsel *evsel, *temp;
>
> __evlist__for_each_entry_safe(list, temp, evsel) {
> + arm_spe_precise_ip_support(evlist, evsel);

this is 'splice' function, you can't configure precise in here

do you need this 'config thing' to be executed on arm only?

if yes, please add something like arch_evsel__config, make it
weak for generic code and define it for arm

if no, just add the call at the end perf_evsel__config I guess

thanks,
jirka

> list_del_init(&evsel->core.node);
> evlist__add(evlist, evsel);
> }
> --
> 2.25.0
>