Re: [PATCH v3 4/4] perf tools: Support "branch-misses:pp" on arm64

Jiri Olsa
2020-02-10T12:25:23Z

On Fri, Feb 07, 2020 at 03:21:42PM +0000, James Clark wrote:

SNIP

>
> #define ITRACE_HELP \
> " i: synthesize instructions events\n" \
> @@ -728,6 +729,11 @@ void auxtrace__free(struct perf_session *session __maybe_unused)
> {
> }
>
> +static inline
> +void auxtrace__preprocess_evlist(struct evlist *evlist __maybe_unused)
> +{
> +}
> +
> static inline
> int auxtrace_index__write(int fd __maybe_unused,
> struct list_head *head __maybe_unused)
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 1548237b6558..84136d0adb29 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -9,6 +9,7 @@
> #include <errno.h>
> #include <inttypes.h>
> #include <poll.h>
> +#include "arm-spe.h"
> #include "cpumap.h"
> #include "util/mmap.h"
> #include "thread_map.h"
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index dc14f4a823cd..c212e2eeeeb2 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -174,7 +174,6 @@ void perf_evsel__exit(struct evsel *evsel);
> void evsel__delete(struct evsel *evsel);
>
> struct callchain_param;
> -

hum? ;-)

jirka

> void perf_evsel__config(struct evsel *evsel,
> struct record_opts *opts,
> struct callchain_param *callchain);
> --
> 2.17.1
>