From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+b96275fd6ad891076ced@syzkaller.appspotmail.com>,
coreteam@netfilter.org, davem@davemloft.net,
florent.fourcot@wifirst.fr, fw@strlen.de, jeremy@azazel.net,
johannes.berg@intel.com, kadlec@netfilter.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
syzkaller-bugs@googlegroups.com
Subject: Re: KASAN: slab-out-of-bounds Read in bitmap_port_destroy
Date: Fri, 24 Jan 2020 12:11:44 +0300 [thread overview]
Message-ID: <20200124091144.GK1847@kadam> (raw)
In-Reply-To: <20200124085521.12504-1-hdanton@sina.com>
On Fri, Jan 24, 2020 at 04:55:21PM +0800, Hillf Danton wrote:
> Ensure four bytes and ask slab to do the rest.
>
> --- a/include/linux/netfilter/ipset/ip_set.h
> +++ b/include/linux/netfilter/ipset/ip_set.h
> @@ -430,7 +430,7 @@ ip6addrptr(const struct sk_buff *skb, bo
> static inline int
> bitmap_bytes(u32 a, u32 b)
> {
> - return 4 * ((((b - a + 8) / 8) + 3) / 4);
> + return 4 + (b - a) / 8;
> }
>
Thanks, but this was already fixed by:
https://lore.kernel.org/netfilter-devel/alpine.DEB.2.20.2001192203200.18095@blackhole.kfki.hu/
regards,
dan carpenter
next parent reply other threads:[~2020-01-24 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200124085521.12504-1-hdanton@sina.com>
2020-01-24 9:11 ` Dan Carpenter [this message]
2020-01-23 23:17 KASAN: slab-out-of-bounds Read in bitmap_port_destroy syzbot
2020-01-24 4:55 ` syzbot
2020-03-14 13:10 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124091144.GK1847@kadam \
--to=dan.carpenter@oracle.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=florent.fourcot@wifirst.fr \
--cc=fw@strlen.de \
--cc=hdanton@sina.com \
--cc=jeremy@azazel.net \
--cc=johannes.berg@intel.com \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=syzbot+b96275fd6ad891076ced@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox