From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB913C2D0DB for ; Fri, 24 Jan 2020 09:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF01C214AF for ; Fri, 24 Jan 2020 09:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858851; bh=GTifRHZot2pqSEr0ua7mI7+H9Cxt5UAbIQ03Dk+Jhg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gx/Big/dJ8JlSkz2WEKbVY8+7ye3h1R6HJiHqjWoE7Xc7A0XVnjyxLnY4QsMLgXEy aTSXAPtSYzQ5zcXjyT+RIrMuRC6RvzFZc3WLm5CqtRMlVIqVtgS05o98x5oHRdTMVy uxSg491XnZ8pWlq6vrrWnbPrURdFc3JaBzfZlDAQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732652AbgAXJkv (ORCPT ); Fri, 24 Jan 2020 04:40:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:38258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731622AbgAXJkt (ORCPT ); Fri, 24 Jan 2020 04:40:49 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E1D720709; Fri, 24 Jan 2020 09:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858848; bh=GTifRHZot2pqSEr0ua7mI7+H9Cxt5UAbIQ03Dk+Jhg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EbWIKEafcmiwiGGGTd19gfV7t/HFX4vXxs6sl4BoEvKv1givRRXe5MYvqywZPdwce fBI75/RrI9FU9k+2nnvucE9TJCP+BLkeHKFhQuwb+qoHUCj9Js+0ynmJSp8WstCbot kdSTSwcnr12u6rD2j9k4ljjMCw3v9BNpB/whSTtk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sakari Ailus , Heikki Krogerus , Andy Shevchenko , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.4 057/102] software node: Get reference to parent swnode in get_parent op Date: Fri, 24 Jan 2020 10:30:58 +0100 Message-Id: <20200124092814.958046246@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092806.004582306@linuxfoundation.org> References: <20200124092806.004582306@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sakari Ailus [ Upstream commit 51c100a651a471fcb8ead1ecc1224471eb0d61b9 ] The software_node_get_parent() returned a pointer to the parent swnode, but did not take a reference to it, leading the caller to put a reference that was not taken. Take that reference now. Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the firmware node framework") Signed-off-by: Sakari Ailus Reviewed-by: Heikki Krogerus Reviewed-by: Andy Shevchenko Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/base/swnode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index a1f3f0994f9f9..d5b4905e2adbd 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -520,7 +520,10 @@ software_node_get_parent(const struct fwnode_handle *fwnode) { struct swnode *swnode = to_swnode(fwnode); - return swnode ? (swnode->parent ? &swnode->parent->fwnode : NULL) : NULL; + if (!swnode || !swnode->parent) + return NULL; + + return fwnode_handle_get(&swnode->parent->fwnode); } static struct fwnode_handle * -- 2.20.1