From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47642C2D0DB for ; Fri, 24 Jan 2020 09:44:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F69F21569 for ; Fri, 24 Jan 2020 09:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859062; bh=V0J3YtmWRb3U0/bhv2WCKbwi0Zy9UPHyBfnYd7xOJZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=s3hLWmu0JQxXA89G4aOAJl50esqLAT/REX5dA/68jSb5b9AqG6uhY0h/m4yMxGeDY R5G3ntQJTZeyybyBRFY8md3ebUbmw6msPDVOLlZ+IT7kV6TXl39eG+gGUdzfFWXUs1 uKU9ytfPIyNWyaMVzkKRfPMVcrT+EdHhfifTzmFs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733300AbgAXJoV (ORCPT ); Fri, 24 Jan 2020 04:44:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:42716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730242AbgAXJoT (ORCPT ); Fri, 24 Jan 2020 04:44:19 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FCE720718; Fri, 24 Jan 2020 09:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859058; bh=V0J3YtmWRb3U0/bhv2WCKbwi0Zy9UPHyBfnYd7xOJZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g4FtXatjVT+ybrSQf98IcW6f9ZRkF/DnE3FTEEp0r4GMMKCUa8J8FJLnhMXd+bL2O IkBwWvDsydtxBChVGzfgXe2rqeOS6sB2tI1khkiwm5bEXiNpJReiR0mUKnVjWadBSB Fazg6h69iujbcoe/Esrl1X7fpbXtaS5J+ci49sc0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Al Viro , Sasha Levin Subject: [PATCH 4.14 025/343] exportfs: fix passing zero to ERR_PTR() warning Date: Fri, 24 Jan 2020 10:27:23 +0100 Message-Id: <20200124092922.899762739@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 909e22e05353a783c526829427e9a8de122fba9c ] Fix a static code checker warning: fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR' The error path for lookup_one_len_unlocked failure should set err to PTR_ERR. Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function") Signed-off-by: YueHaibing Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/exportfs/expfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c index a561ae17cf435..c08960040dd05 100644 --- a/fs/exportfs/expfs.c +++ b/fs/exportfs/expfs.c @@ -147,6 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt, tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf)); if (IS_ERR(tmp)) { dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp)); + err = PTR_ERR(tmp); goto out_err; } if (tmp != dentry) { -- 2.20.1