From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3286BC2D0DB for ; Fri, 24 Jan 2020 09:45:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F366321556 for ; Fri, 24 Jan 2020 09:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859131; bh=8KfkYWP9FNW3KMOM4ZiXmt7sOFAj8EqdP+KLjjnJ3xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=isnrnlX4VaMvOxZiuvlr9A+k52jZL8PS/zVOni7e4UzV8oj1w963nHkYy3r+2mZ6c 7MM67f9nhvJdLmE1Hczs4/fBQJ/IPKAAqHvwPYhfclmDMsqWMXx9Mpkgm2vd3tguik iVnfRoNhgtTVbuVEA1j0XQHfof72L7E8jq2rBqbU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733013AbgAXJpa (ORCPT ); Fri, 24 Jan 2020 04:45:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:44380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730712AbgAXJp2 (ORCPT ); Fri, 24 Jan 2020 04:45:28 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A114521556; Fri, 24 Jan 2020 09:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859128; bh=8KfkYWP9FNW3KMOM4ZiXmt7sOFAj8EqdP+KLjjnJ3xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z//bfFxgTSQX9HO0SHVKz//t/qfyA7UIrKky/Rs3FPHOnCfexPOnLCmnh8C50OzoP z7CfE04vJVCTcMjcRC7T9eOsCaKfujIMPjiZxQl/mGPruGMUzcWvD6HewVtPURgOX6 Jvzckz7Cnc3SPT+GPEWbbBJO+ABwa0+ab9V5sBHw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Stephen Boyd , Sasha Levin Subject: [PATCH 4.14 049/343] clk: imx7d: fix refcount leak in imx7d_clocks_init() Date: Fri, 24 Jan 2020 10:27:47 +0100 Message-Id: <20200124092926.173177480@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit 5f8c183a996b76bb09748073c856e4246fd4ce95 ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Fixes: 8f6d8094b215 ("ARM: imx: add imx7d clk tree support") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/imx/clk-imx7d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index 0ac9b30c8b906..9f5e5b9d4a25a 100644 --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d.c @@ -416,6 +416,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) np = of_find_compatible_node(NULL, NULL, "fsl,imx7d-anatop"); base = of_iomap(np, 0); WARN_ON(!base); + of_node_put(np); clks[IMX7D_PLL_ARM_MAIN_SRC] = imx_clk_mux("pll_arm_main_src", base + 0x60, 14, 2, pll_bypass_src_sel, ARRAY_SIZE(pll_bypass_src_sel)); clks[IMX7D_PLL_DRAM_MAIN_SRC] = imx_clk_mux("pll_dram_main_src", base + 0x70, 14, 2, pll_bypass_src_sel, ARRAY_SIZE(pll_bypass_src_sel)); -- 2.20.1