From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6129AC32771 for ; Fri, 24 Jan 2020 09:54:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C08E20709 for ; Fri, 24 Jan 2020 09:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859663; bh=rnzdax1ADAL6q2xgTmLbW/c2C9fvrmPaOsAZoDD7E7M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YJhZZeHVO+pj1prKneGGigRcnDp8zLP/5BkoAD+MIAZtVAEkg7wcgYnFO+9ADNbg5 7NPFxUY0m+A1AdJS9JESfr7acfB6Ypfb3ZEntDj0jjPxr8yJ2jgCa/I44H6Ox722iI z2lblJa2rDftWIXqsRKsDkXoweK7klLBCTcxHSxk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388358AbgAXJyW (ORCPT ); Fri, 24 Jan 2020 04:54:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:57318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731584AbgAXJyV (ORCPT ); Fri, 24 Jan 2020 04:54:21 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E130214DB; Fri, 24 Jan 2020 09:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859660; bh=rnzdax1ADAL6q2xgTmLbW/c2C9fvrmPaOsAZoDD7E7M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r6fZ3LxbEV7NA1KptkJSD56ItAec+9i8q1ehmNPyJ4COV/RnX6mTnykUmK746Eb0B /nEfkSnUK+rVvxjKi2W0EAXAAxtZVE/ysY64/Gr1KUvkdshbtgCw6D5vm49HFh84k4 s9l4SDGMd4HNPK4zteeMMaebUgzberxwCxPNIrYw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Yunsheng Lin , Huazhong Tan , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 167/343] net: hns3: fix for vport->bw_limit overflow problem Date: Fri, 24 Jan 2020 10:29:45 +0100 Message-Id: <20200124092941.999013881@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yunsheng Lin [ Upstream commit 2566f10676ba996b745e138f54f3e2f974311692 ] When setting vport->bw_limit to hdev->tm_info.pg_info[0].bw_limit in hclge_tm_vport_tc_info_update, vport->bw_limit can be as big as HCLGE_ETHER_MAX_RATE (100000), which can not fit into u16 (65535). So this patch fixes it by using u32 for vport->bw_limit. Fixes: 848440544b41 ("net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver") Reported-by: Dan Carpenter Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h index 9fcfd93954245..a4c5e72d6012a 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h @@ -480,7 +480,7 @@ struct hclge_vport { u16 alloc_rss_size; u16 qs_offset; - u16 bw_limit; /* VSI BW Limit (0 = disabled) */ + u32 bw_limit; /* VSI BW Limit (0 = disabled) */ u8 dwrr; int vport_id; -- 2.20.1