From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7D7C2D0DB for ; Fri, 24 Jan 2020 10:07:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBD102077C for ; Fri, 24 Jan 2020 10:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579860419; bh=5NJeAx/yUKp37wwGph0EfTOp+ULE/9/vx74Hodzd7rg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=w/gCBSQcXdcX280trE3CTPz0byu3j+f5Etx+XtXWjsj2Rc7X9DuZHu9coTGOKt8qV Fg5iaHGUk47AN1GCdFdJeyQZR5M+if1xFYnsk4ttjaQ56rTmgWlgjZyNSYq1rvFPqg 0SD0oxnAt7TufX7xMyEZxxqvApeZEsVnf3/ShxBg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389341AbgAXKG6 (ORCPT ); Fri, 24 Jan 2020 05:06:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:43488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730766AbgAXKG4 (ORCPT ); Fri, 24 Jan 2020 05:06:56 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE0A1206F0; Fri, 24 Jan 2020 10:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579860416; bh=5NJeAx/yUKp37wwGph0EfTOp+ULE/9/vx74Hodzd7rg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CKL/3ENHRN1LxMviz8tZGWvQ7avc/k5Dyv/BasjFlfFTHZtPPtKYewJgn8hHhYlrM SToZIVYJdHlHMekSXyBDK+ix5SFuVGPEIYG5UoqfAdPHvp1yk6VufDM/ej5ikW/ITP jkT8SLEgKAcd2yAY9hoN27gJ2kzw9530DV/gPC7A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 309/343] net: hisilicon: Fix signedness bug in hix5hd2_dev_probe() Date: Fri, 24 Jan 2020 10:32:07 +0100 Message-Id: <20200124093000.535459287@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 002dfe8085255b7bf1e0758c3d195c5412d35be9 ] The "priv->phy_mode" variable is an enum and in this context GCC will treat it as unsigned to the error handling will never trigger. Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c index aab6fb10af94a..6adf6831d120a 100644 --- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c +++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c @@ -1202,7 +1202,7 @@ static int hix5hd2_dev_probe(struct platform_device *pdev) goto err_free_mdio; priv->phy_mode = of_get_phy_mode(node); - if (priv->phy_mode < 0) { + if ((int)priv->phy_mode < 0) { netdev_err(ndev, "not find phy-mode\n"); ret = -EINVAL; goto err_mdiobus; -- 2.20.1