From: Anders Roxell <anders.roxell@linaro.org>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Anders Roxell <anders.roxell@linaro.org>
Subject: [PATCH] x86: Kconfig: make CMDLINE_OVERRIDE depend on CMDLINE
Date: Fri, 24 Jan 2020 12:46:15 +0100 [thread overview]
Message-ID: <20200124114615.11577-1-anders.roxell@linaro.org> (raw)
When trying to boot an allmodconfig kernel that is build with
KCONFIG_ALLCONFIG=$(pwd)/arch/x86/configs/x86_64_defconfig, it doesn't
boot since CONFIG_CMDLINE_OVERRIDE gets enabled. Which forces the user
to pass the full cmdline to CONFIG_CMDLINE="...".
Rework so that CONFIG_CMDLINE_OVERRIDE gets set only if CONFIG_CMDLINE
is set to something except an empty string.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index f2dcd9ab6ef6..598b6325a027 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2447,7 +2447,7 @@ config CMDLINE
config CMDLINE_OVERRIDE
bool "Built-in command line overrides boot loader arguments"
- depends on CMDLINE_BOOL
+ depends on CMDLINE_BOOL && CMDLINE != ""
---help---
Set this option to 'Y' to have the kernel ignore the boot loader
command line, and use ONLY the built-in command line.
--
2.20.1
next reply other threads:[~2020-01-24 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 11:46 Anders Roxell [this message]
2020-02-24 21:36 ` [PATCH] x86: Kconfig: make CMDLINE_OVERRIDE depend on CMDLINE Borislav Petkov
2020-02-26 12:37 ` [tip: x86/build] x86/Kconfig: Make CMDLINE_OVERRIDE depend on non-empty CMDLINE tip-bot2 for Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124114615.11577-1-anders.roxell@linaro.org \
--to=anders.roxell@linaro.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox