* [PATCH] drm/panel: Fix boe,tv101wum-n53 htotal timing
@ 2020-01-25 5:02 Nicolas Boichat
2020-01-25 6:12 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Boichat @ 2020-01-25 5:02 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Jitao Shi, Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
The datasheet suggests 60 for tHFP, so let's adjust the number
accordingly.
This also makes the framerate be 60Hz as intended:
159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10))
=> 60.00 Hz
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---
This also matches the values that we use in our chromeos-4.19
vendor kernel.
Applies on top or drm-misc/drm-misc-next.
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index 01faf8597700005..48a164257d18c35 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = {
.hdisplay = 1200,
.hsync_start = 1200 + 80,
.hsync_end = 1200 + 80 + 24,
- .htotal = 1200 + 80 + 24 + 40,
+ .htotal = 1200 + 80 + 24 + 60,
.vdisplay = 1920,
.vsync_start = 1920 + 20,
.vsync_end = 1920 + 20 + 4,
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panel: Fix boe,tv101wum-n53 htotal timing
2020-01-25 5:02 [PATCH] drm/panel: Fix boe,tv101wum-n53 htotal timing Nicolas Boichat
@ 2020-01-25 6:12 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-01-25 6:12 UTC (permalink / raw)
To: Nicolas Boichat
Cc: Jitao Shi, Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
Hi Nicolas.
On Sat, Jan 25, 2020 at 01:02:56PM +0800, Nicolas Boichat wrote:
> The datasheet suggests 60 for tHFP, so let's adjust the number
> accordingly.
>
> This also makes the framerate be 60Hz as intended:
> 159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10))
> => 60.00 Hz
>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Thanks. Added Fixes: tag and applied to drm-misc-next.
Sam
>
> ---
>
> This also matches the values that we use in our chromeos-4.19
> vendor kernel.
>
> Applies on top or drm-misc/drm-misc-next.
>
> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 01faf8597700005..48a164257d18c35 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = {
> .hdisplay = 1200,
> .hsync_start = 1200 + 80,
> .hsync_end = 1200 + 80 + 24,
> - .htotal = 1200 + 80 + 24 + 40,
> + .htotal = 1200 + 80 + 24 + 60,
> .vdisplay = 1920,
> .vsync_start = 1920 + 20,
> .vsync_end = 1920 + 20 + 4,
> --
> 2.25.0.341.g760bfbb309-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-25 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-25 5:02 [PATCH] drm/panel: Fix boe,tv101wum-n53 htotal timing Nicolas Boichat
2020-01-25 6:12 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox