[PATCH] staging: rtl8723bs: hal: fix condition with no effect

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] staging: rtl8723bs: hal: fix condition with no effect
@ 2020-01-25 13:46 Saurav Girepunje
  2020-02-07  9:21 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2020-01-25 13:46 UTC (permalink / raw)
  To: gregkh, saurav.girepunje, devel, linux-kernel; +Cc: saurav.girepunje

fix warning reorted by coccicheck
WARNING: possible condition with no effect (if == else)

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
  drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
index 02da0a8..8dfa9b9 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
@@ -1610,8 +1610,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(13);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(14);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(15);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(15);
  				} else {
@@ -1619,8 +1617,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(9);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(10);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(11);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(11);
  				}
@@ -1630,8 +1626,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(5);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(6);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(7);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(7);
  				} else {
@@ -1639,8 +1633,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(1);
  					else if (maxInterval == 2)
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(2);
-					else if (maxInterval == 3)
-						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(3);
  					else
  						HAL_BTC8723B2ANT_DMA_DURATION_ADJUST(3);
  				}
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8723bs: hal: fix condition with no effect
  2020-01-25 13:46 [PATCH] staging: rtl8723bs: hal: fix condition with no effect Saurav Girepunje
@ 2020-02-07  9:21 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-02-07  9:21 UTC (permalink / raw)
  To: Saurav Girepunje; +Cc: devel, linux-kernel, saurav.girepunje

On Sat, Jan 25, 2020 at 07:16:04PM +0530, Saurav Girepunje wrote:
> fix warning reorted by coccicheck
> WARNING: possible condition with no effect (if == else)
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 8 --------
>  1 file changed, 8 deletions(-)

Patch does not apply to Linus's latest tree :(

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-07  9:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-25 13:46 [PATCH] staging: rtl8723bs: hal: fix condition with no effect Saurav Girepunje
2020-02-07  9:21 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox