From: Johan Hovold <johan@kernel.org>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced.
Date: Sun, 26 Jan 2020 12:04:39 +0100 [thread overview]
Message-ID: <20200126110439.GL8375@localhost> (raw)
In-Reply-To: <20200126083130.GA17725@google.com>
On Sun, Jan 26, 2020 at 02:01:30PM +0530, Saurav Girepunje wrote:
> Fix the warning reported by cocci check.
>
> Changes:
>
> In queue_work fw dereference before it actually get assigned.
> move queue_work before gb_bootrom_set_timeout.
Nope. As I said yesterday, you need to verify the output of any static
checkers you use.
The code may be unnecessarily subtle, but there's no way fw can be
dereferenced before being initialised currently.
> -queue_work:
> /* Refresh timeout */
> if (!ret && (offset + size == fw->size))
Specifically, the second operand is never evaluated if ret is non-zero.
> next_request = NEXT_REQ_READY_TO_BOOT;
> - else
> - next_request = NEXT_REQ_GET_FIRMWARE;
>
> +queue_work:
> gb_bootrom_set_timeout(bootrom, next_request, NEXT_REQ_TIMEOUT_MS);
>
> return ret;
Johan
next prev parent reply other threads:[~2020-01-26 11:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 8:31 [PATCH] staging: greybus: fix fw is NULL but dereferenced Saurav Girepunje
2020-01-26 11:04 ` Johan Hovold [this message]
2020-01-26 18:30 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 10:19 Jian Dong
2021-03-25 10:29 ` Greg KH
2021-03-25 11:03 ` Jian Dong
2021-03-25 11:32 ` Greg KH
2021-03-25 10:50 ` Dan Carpenter
2021-03-25 10:51 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126110439.GL8375@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox