From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fzvl=3P=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 61E9BC2D0DB
	for <linux-kernel@archiver.kernel.org>; Sun, 26 Jan 2020 20:50:17 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 32C7A20716
	for <linux-kernel@archiver.kernel.org>; Sun, 26 Jan 2020 20:50:17 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727295AbgAZUuQ (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Sun, 26 Jan 2020 15:50:16 -0500
Received: from mail.kernel.org ([198.145.29.99]:44640 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726144AbgAZUuP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 26 Jan 2020 15:50:15 -0500
Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id DB9BD206F0;
        Sun, 26 Jan 2020 20:50:14 +0000 (UTC)
Date:   Sun, 26 Jan 2020 15:50:13 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Joe Perches <joe@perches.com>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [for-next][PATCH 7/7] tracing: Use pr_err() instead of WARN()
 for memory failures
Message-ID: <20200126155013.5cfc23aa@rorschach.local.home>
In-Reply-To: <e70ff75e9712478704fad44ac6b66c86a45df6a6.camel@perches.com>
References: <20200126191932.984391723@goodmis.org>
        <20200126192021.350763989@goodmis.org>
        <e70ff75e9712478704fad44ac6b66c86a45df6a6.camel@perches.com>
X-Mailer: Claws Mail 3.17.4git76 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 26 Jan 2020 12:38:55 -0800
Joe Perches <joe@perches.com> wrote:

> On Sun, 2020-01-26 at 14:19 -0500, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> > 
> > As warnings can trigger panics, especially when "panic_on_warn" is set,
> > memory failure warnings can cause panics and fail fuzz testers that are
> > stressing memory.
> > 
> > Create a MEM_FAIL() macro to use instead of WARN() in the tracing code
> > (perhaps this should be a kernel wide macro?), and use that for memory
> > failure issues. This should stop failing fuzz tests due to warnings.  
> 
> It looks as if most of these could just be removed instead
> as there is an existing dump_stack() on failure.

That sounds more generic. This is specific for my own tracing tests to
look for. As the point is, it is *not* to dump_stack, and still report
the error.

-- Steve