From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB03C35240 for ; Sun, 26 Jan 2020 23:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE62820700 for ; Sun, 26 Jan 2020 23:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XzLY/OX8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbgAZXwi (ORCPT ); Sun, 26 Jan 2020 18:52:38 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55040 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgAZXwi (ORCPT ); Sun, 26 Jan 2020 18:52:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1sMrnh3SigC44z/XmPsI9gIHq4VNk82ikUxOnQh0bFs=; b=XzLY/OX8zrdJNDja97v1DvWKUQ /r74uzPRQjR4iXjU5wmvYvL7py+ti6UfezASwQExSkl4Pk3i/7haDTO0ziSVXvV/V9n5IHYPo4vm2 j2EedibUzATs0+w8s3nYRvSnQB88oLJyG0dInIik2oXryOPEbmLYhCBQgaf0v7/nJW6s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ivrhf-0003b7-Fm; Mon, 27 Jan 2020 00:52:31 +0100 Date: Mon, 27 Jan 2020 00:52:31 +0100 From: Andrew Lunn To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jakub Kicinski , Jiri Pirko , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/7] ethtool: provide message mask with DEBUG_GET request Message-ID: <20200126235231.GB12816@lunn.ch> References: <9f81d98d866d538642696339d9ee5c08a399a384.1580075977.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f81d98d866d538642696339d9ee5c08a399a384.1580075977.git.mkubecek@suse.cz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 26, 2020 at 11:11:04PM +0100, Michal Kubecek wrote: > Implement DEBUG_GET request to get debugging settings for a device. At the > moment, only message mask corresponding to message level as reported by > ETHTOOL_GMSGLVL ioctl request is provided. (It is called message level in > ioctl interface but almost all drivers interpret it as a bit mask.) > > As part of the implementation, provide symbolic names for message mask bits > as ETH_SS_MSG_CLASSES string set. > > Signed-off-by: Michal Kubecek Reviewed-by: Andrew Lunn Andrew