Re: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request

Michal Kubecek
2020-01-27T06:25:00Z

On Mon, Jan 27, 2020 at 02:04:22AM +0100, Andrew Lunn wrote:
> > + ret = ethnl_parse_header(&req_info, tb[ETHTOOL_A_DEBUG_HEADER],
> > + genl_info_net(info), info->extack, true);
>
> > + dev_put(dev);
>
> Hi Michal
>
> While reviewing this patch i noticed this dev_put() and wondered where
> the dev_get() was. It is hiding inside ethnl_parse_header(). The
> documentation does make it clear it takes a reference on the device,
> but how many people read the documentation? I would not be too
> surprised if at some point in the future we have bugs from missing
> dev_put().
>
> Could we make this a bit more explicit by calling it
> ethnl_parse_header_dev_get(). It is rather long though.

Good point, I'll think about the name some more and send a cleanup patch
when net-next reopens.

Michal