From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables
Date: Mon, 27 Jan 2020 11:09:53 +0300 [thread overview]
Message-ID: <20200127080953.GQ1847@kadam> (raw)
In-Reply-To: <20200125084403.GA3386@google.com>
On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote:
> fix uninitialized variables issue found using static code analysis tool
>
> (error) Uninitialized variable: offset
> (error) Uninitialized variable: size
>
These are false positives as Johan said. Don't change the code just to
make the static analysis tool happy, fix the tools instead.
Also the patch doesn't apply. Read the first paragraph of
Documentation/process/email-clients.rst and figure out why it's not
working.
regards,
dan carpenter
prev parent reply other threads:[~2020-01-27 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 8:44 [PATCH] staging: greybus: bootrom: fix uninitialized variables Saurav Girepunje
2020-01-25 10:00 ` Johan Hovold
2020-01-25 12:14 ` SAURAV GIREPUNJE
2020-01-27 14:10 ` [greybus-dev] " Alex Elder
2020-01-27 8:09 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127080953.GQ1847@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox