From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: gregkh@linuxfoundation.org, nishkadg.linux@gmail.com,
wambui.karugax@gmail.com, julia.lawall@lip6.fr,
benniciemanuel78@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: rtl8723bs: core: fix condition with no effect
Date: Mon, 27 Jan 2020 11:26:42 +0300 [thread overview]
Message-ID: <20200127081812.GT1847@kadam> (raw)
In-Reply-To: <20200125133438.GA4211@google.com>
On Sat, Jan 25, 2020 at 07:04:38PM +0530, Saurav Girepunje wrote:
> fix warning reorted by coccicheck
> WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
This one looks good.
The difference between this one and the last one, is that this stuff
looks like documentation but it's just a lot of garbage dead code so
it's good to delete it.
But unfortunately, these patches don't apply. Please read
Documentation/process/email-clients.rst
regards,
dan carpenter
prev parent reply other threads:[~2020-01-27 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 13:34 [PATCH] staging: rtl8723bs: core: fix condition with no effect Saurav Girepunje
2020-01-27 8:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127081812.GT1847@kadam \
--to=dan.carpenter@oracle.com \
--cc=benniciemanuel78@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox