From: <sjpark@amazon.com>
To: <jgross@suse.com>, <roger.pau@citrix.com>, <axboe@kernel.dk>
Cc: SeongJae Park <sjpark@amazon.de>, <konrad.wilk@oracle.com>,
<pdurrant@amazon.com>, <xen-devel@lists.xenproject.org>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v14 5/5] xen/blkback: Consistently insert one empty line between functions
Date: Mon, 27 Jan 2020 09:19:57 +0100 [thread overview]
Message-ID: <20200127081957.21509-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200127081812.21216-1-sjpark@amazon.com>
From: SeongJae Park <sjpark@amazon.de>
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
drivers/block/xen-blkback/xenbus.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 55960190b774..42944d41aea0 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -467,7 +467,6 @@ static void xenvbd_sysfs_delif(struct xenbus_device *dev)
device_remove_file(&dev->dev, &dev_attr_physical_device);
}
-
static void xen_vbd_free(struct xen_vbd *vbd)
{
if (vbd->bdev)
@@ -524,6 +523,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
handle, blkif->domid);
return 0;
}
+
static int xen_blkbk_remove(struct xenbus_device *dev)
{
struct backend_info *be = dev_get_drvdata(&dev->dev);
@@ -607,6 +607,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
if (err)
dev_warn(&dev->dev, "writing feature-discard (%d)", err);
}
+
int xen_blkbk_barrier(struct xenbus_transaction xbt,
struct backend_info *be, int state)
{
@@ -691,7 +692,6 @@ static int xen_blkbk_probe(struct xenbus_device *dev,
return err;
}
-
/*
* Callback received when the hotplug scripts have placed the physical-device
* node. Read it and the mode node, and create a vbd. If the frontend is
@@ -783,7 +783,6 @@ static void backend_changed(struct xenbus_watch *watch,
}
}
-
/*
* Callback received when the frontend's state changes.
*/
@@ -858,7 +857,6 @@ static void frontend_changed(struct xenbus_device *dev,
}
}
-
/* Once a memory pressure is detected, squeeze free page pools for a while. */
static unsigned int buffer_squeeze_duration_ms = 10;
module_param_named(buffer_squeeze_duration_ms,
@@ -881,7 +879,6 @@ static void reclaim_memory(struct xenbus_device *dev)
/* ** Connection ** */
-
/*
* Write the physical details regarding the block device to the store, and
* switch to Connected state.
--
2.17.1
next prev parent reply other threads:[~2020-01-27 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 8:18 [PATCH v14 0/5] xenbus/backend: Add memory pressure handler callback sjpark
2020-01-27 8:18 ` [PATCH v14 1/5] " sjpark
2020-01-27 8:18 ` [PATCH v14 2/5] xenbus/backend: Protect xenbus callback with lock sjpark
2020-01-27 8:18 ` [PATCH v14 3/5] xen/blkback: Squeeze page pools if a memory pressure is detected sjpark
2020-01-27 8:18 ` [PATCH v14 4/5] xen/blkback: Remove unnecessary static variable name prefixes sjpark
2020-01-27 8:19 ` sjpark [this message]
2020-01-30 13:21 ` [Xen-devel] [PATCH v14 0/5] xenbus/backend: Add memory pressure handler callback Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127081957.21509-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=axboe@kernel.dk \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdurrant@amazon.com \
--cc=roger.pau@citrix.com \
--cc=sjpark@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox