From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22D8C33CB3 for ; Tue, 28 Jan 2020 07:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A0592173E for ; Tue, 28 Jan 2020 07:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580197854; bh=JCv/NyT1mrCMzv4okq1iCXZ4H3lbeVqPn9G8p80jpHo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IOaKnPXzykIhKLXr07PF+/u4HdLqp6j4i0pkfwbhXeNXQsPVmkDOl29M0ipCNQg4g XQMMeEafGYRe/TVi6wqRw1mFrzVeUZse0yRibIUnIfhvStslyAJBoBCJC8MgnUXFt9 EANVR2wiMQnYMgcHmOo024W71nctc0eM1u5ydTyo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725901AbgA1Hux (ORCPT ); Tue, 28 Jan 2020 02:50:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:54808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgA1Hux (ORCPT ); Tue, 28 Jan 2020 02:50:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70EF620678; Tue, 28 Jan 2020 07:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580197853; bh=JCv/NyT1mrCMzv4okq1iCXZ4H3lbeVqPn9G8p80jpHo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dyt9jvL5L0NnbDojGspxXNnhsNhkwfABkWI0Z4r7ASOU7AsbfRmykIZJaJ56g6DWJ Np6+0WBmRaH8cp1VdbYbrJkoyFgFQyhoYJ5HGPD7EG4gFeGZsZEGYNjIsquamurMHO +zA1HLMGAxKsUlurc2zGowhd4rL6JzqZEubIQzSM= Date: Tue, 28 Jan 2020 08:50:50 +0100 From: Greg Kroah-Hartman To: Kees Cook Cc: Alexander Popov , Arnd Bergmann , linux-kernel@vger.kernel.org, notify@kernel.org Subject: Re: [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose Message-ID: <20200128075050.GC2105706@kroah.com> References: <20200102234907.585508-1-alex.popov@linux.com> <202001271514.345A5CC9C@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202001271514.345A5CC9C@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 27, 2020 at 03:15:08PM -0800, Kees Cook wrote: > On Wed, Jan 22, 2020 at 02:58:44PM +0300, Alexander Popov wrote: > > On 03.01.2020 02:49, Alexander Popov wrote: > > > Make the stack erasing test more verbose about the errors that it > > > can detect. > > > > > > Signed-off-by: Alexander Popov > > > --- > > > drivers/misc/lkdtm/stackleak.c | 25 +++++++++++++++++-------- > > > 1 file changed, 17 insertions(+), 8 deletions(-) > > > > Hello! > > > > Pinging about this version of the patch. > > > > Kees, it uses dump_stack() instead of BUG(), as we negotiated. > > Yup, this is in my queue -- I've just gotten back from travelling and > will get to it shortly. :) > > Greg, feel free to take this directly if you want, too. If I were to take it, it would have to wait until after 5.6-rc1, sorry. thanks, greg k-h