From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alexander Popov <alex.popov@linux.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, notify@kernel.org
Subject: Re: [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose
Date: Tue, 28 Jan 2020 15:03:10 -0800 [thread overview]
Message-ID: <202001281502.F4977FD279@keescook> (raw)
In-Reply-To: <20200128075050.GC2105706@kroah.com>
On Tue, Jan 28, 2020 at 08:50:50AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 27, 2020 at 03:15:08PM -0800, Kees Cook wrote:
> > On Wed, Jan 22, 2020 at 02:58:44PM +0300, Alexander Popov wrote:
> > > On 03.01.2020 02:49, Alexander Popov wrote:
> > > > Make the stack erasing test more verbose about the errors that it
> > > > can detect.
> > > >
> > > > Signed-off-by: Alexander Popov <alex.popov@linux.com>
> > > > ---
> > > > drivers/misc/lkdtm/stackleak.c | 25 +++++++++++++++++--------
> > > > 1 file changed, 17 insertions(+), 8 deletions(-)
> > >
> > > Hello!
> > >
> > > Pinging about this version of the patch.
> > >
> > > Kees, it uses dump_stack() instead of BUG(), as we negotiated.
> >
> > Yup, this is in my queue -- I've just gotten back from travelling and
> > will get to it shortly. :)
> >
> > Greg, feel free to take this directly if you want, too.
>
> If I were to take it, it would have to wait until after 5.6-rc1, sorry.
Well, it has to go via drivers/misc anyway, so I think timing is no
different. I would consider this a feature patch, not a bug fix, too.
--
Kees Cook
prev parent reply other threads:[~2020-01-28 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 23:49 [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose Alexander Popov
2020-01-14 12:14 ` Alexander Popov
2020-01-22 11:58 ` Alexander Popov
2020-01-27 23:15 ` Kees Cook
2020-01-28 7:50 ` Greg Kroah-Hartman
2020-01-28 23:03 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001281502.F4977FD279@keescook \
--to=keescook@chromium.org \
--cc=alex.popov@linux.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notify@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox