* [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml
@ 2020-01-22 13:46 Dafna Hirschfeld
2020-01-23 14:25 ` Rob Herring
2020-01-28 18:26 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Dafna Hirschfeld @ 2020-01-22 13:46 UTC (permalink / raw)
To: linux-arm-msm
Cc: agross, bjorn.andersson, mturquette, sboyd, robh+dt, mark.rutland,
devicetree, linux-kernel, dafna.hirschfeld, helen.koike, ezequiel,
kernel, dafna3
Running `make dt_binging_check`, gives the error:
DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
FATAL ERROR: Unable to parse input tree
This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
is defined in qcom,rpmcc.h but the include of this header is missing.
Add the include to fix the error.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
index 19d00794fe7d..50ff07f80acb 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
@@ -220,6 +220,7 @@ examples:
# Example of MSM8998 GCC:
- |
+ #include <dt-bindings/clock/qcom,rpmcc.h>
clock-controller@100000 {
compatible = "qcom,gcc-msm8998";
#clock-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml
2020-01-22 13:46 [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml Dafna Hirschfeld
@ 2020-01-23 14:25 ` Rob Herring
2020-01-28 18:26 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-01-23 14:25 UTC (permalink / raw)
To: Dafna Hirschfeld
Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Mark Rutland, devicetree,
linux-kernel@vger.kernel.org, Helen Koike, Ezequiel Garcia,
Collabora Kernel ML, dafna3
On Wed, Jan 22, 2020 at 7:46 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
>
> Running `make dt_binging_check`, gives the error:
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
>
Fixes: d109ea0970cf ("dt-bindings: clock: Document external clocks for
MSM8998 gcc")
Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 19d00794fe7d..50ff07f80acb 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -220,6 +220,7 @@ examples:
>
> # Example of MSM8998 GCC:
> - |
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> clock-controller@100000 {
> compatible = "qcom,gcc-msm8998";
> #clock-cells = <1>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml
2020-01-22 13:46 [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml Dafna Hirschfeld
2020-01-23 14:25 ` Rob Herring
@ 2020-01-28 18:26 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-01-28 18:26 UTC (permalink / raw)
To: Dafna Hirschfeld, linux-arm-msm
Cc: agross, bjorn.andersson, mturquette, robh+dt, mark.rutland,
devicetree, linux-kernel, dafna.hirschfeld, helen.koike, ezequiel,
kernel, dafna3
Quoting Dafna Hirschfeld (2020-01-22 05:46:39)
> Running `make dt_binging_check`, gives the error:
>
> DTC Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-28 18:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-22 13:46 [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml Dafna Hirschfeld
2020-01-23 14:25 ` Rob Herring
2020-01-28 18:26 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox