Re: [PATCH 09/22] staging: exfat: Rename variable "Size" to "size"

Pragat Pandya
2020-01-29T10:58:47Z

On Wed, 2020-01-29 at 11:50 +0100, Greg KH wrote:
> On Wed, Jan 29, 2020 at 04:10:39PM +0530, Pragat Pandya wrote:
> > On Mon, 2020-01-27 at 14:57 +0300, Dan Carpenter wrote:
> > > On Mon, Jan 27, 2020 at 03:43:30PM +0530, Pragat Pandya wrote:
> > > > Change all the occurences of "Size" to "size" in exfat.
> > > >
> > > > Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
> > > > ---
> > > > drivers/staging/exfat/exfat.h | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/exfat/exfat.h
> > > > b/drivers/staging/exfat/exfat.h
> > > > index 52f314d50b91..a228350acdb4 100644
> > > > --- a/drivers/staging/exfat/exfat.h
> > > > +++ b/drivers/staging/exfat/exfat.h
> > > > @@ -233,7 +233,7 @@ struct date_time_t {
> > > >
> > > > struct part_info_t {
> > > > u32 offset; /* start sector number of the
> > > > partition */
> > > > - u32 Size; /* in sectors */
> > > > + u32 size; /* in sectors */
> > > > };
> > >
> > > We just renamed all the struct members of this without changing
> > > any
> > > users. Which suggests that this is unused and can be deleted.
> > >
> > > regards,
> > > dan carpenter
> > >
> >
> > Can I just drop this commit from this patchset and do a separate
> > patch
> > to remove the unused structure?
>
> Drop this one, and the other ones that touch this structure, and do a
> separate patch. This series needs fixing up anyway, I can't take it
> as-is.
>
> thanks,
>
> greg k-h

Ok, will do that.

Regards,
pragat pandya