Re: [PATCH v6 09/16] dmaengine: tegra-apb: Remove unneeded initialization of tdc->config_init

Jon Hunter
2020-01-30T14:09:01Z

On 30/01/2020 04:37, Dmitry Osipenko wrote:
> There is no need to re-initialize the already initialized variables.
> The tdc->config_init=false after driver's probe and after channel's
> freeing, so there is no need to re-initialize it on the channel's
> allocation.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/dma/tegra20-apb-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index b4535b3a07ce..7158bd3145c4 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -1284,7 +1284,6 @@ static int tegra_dma_alloc_chan_resources(struct dma_chan *dc)
> int ret;
>
> dma_cookie_init(&tdc->dma_chan);
> - tdc->config_init = false;
>
> ret = pm_runtime_get_sync(tdma->dev);
> if (ret < 0)
>

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

--
nvpublic