* [PATCH] openrisc: configs: Cleanup CONFIG_CROSS_COMPILE
@ 2020-01-30 19:19 Krzysztof Kozlowski
2020-01-30 21:38 ` Stafford Horne
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-30 19:19 UTC (permalink / raw)
To: Jonas Bonn, Stefan Kristiansson, Stafford Horne, Andrew Morton,
openrisc, linux-kernel
Cc: Krzysztof Kozlowski
CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove
CONFIG_CROSS_COMPILE support").
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/openrisc/configs/or1ksim_defconfig | 1 -
arch/openrisc/configs/simple_smp_defconfig | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/openrisc/configs/or1ksim_defconfig b/arch/openrisc/configs/or1ksim_defconfig
index d8ff4f8ffb88..75f2da324d0e 100644
--- a/arch/openrisc/configs/or1ksim_defconfig
+++ b/arch/openrisc/configs/or1ksim_defconfig
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
CONFIG_NO_HZ=y
CONFIG_LOG_BUF_SHIFT=14
CONFIG_BLK_DEV_INITRD=y
diff --git a/arch/openrisc/configs/simple_smp_defconfig b/arch/openrisc/configs/simple_smp_defconfig
index 64278992df9c..ff49d868e040 100644
--- a/arch/openrisc/configs/simple_smp_defconfig
+++ b/arch/openrisc/configs/simple_smp_defconfig
@@ -1,4 +1,3 @@
-CONFIG_CROSS_COMPILE="or1k-linux-"
CONFIG_LOCALVERSION="-simple-smp"
CONFIG_NO_HZ=y
CONFIG_LOG_BUF_SHIFT=14
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] openrisc: configs: Cleanup CONFIG_CROSS_COMPILE 2020-01-30 19:19 [PATCH] openrisc: configs: Cleanup CONFIG_CROSS_COMPILE Krzysztof Kozlowski @ 2020-01-30 21:38 ` Stafford Horne 2020-01-31 2:19 ` Masahiro Yamada 2020-01-31 8:25 ` Krzysztof Kozlowski 0 siblings, 2 replies; 4+ messages in thread From: Stafford Horne @ 2020-01-30 21:38 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Jonas Bonn, Stefan Kristiansson, Andrew Morton, openrisc, linux-kernel, yamada.masahiro +cc: Masahiro, On Thu, Jan 30, 2020 at 08:19:38PM +0100, Krzysztof Kozlowski wrote: > CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove > CONFIG_CROSS_COMPILE support"). I see this patch is already in, but does it break 0-day test tools that depend on this CONFIG_CROSS_COMPILE setup? I guess its been in since 2018, so there should be no problem. Can you also help to update "Documentation/openrisc/openrisc_port.rst"? It mentions the build steps are: Build the Linux kernel as usual:: make ARCH=openrisc defconfig make ARCH=openrisc This now changes, I used to use `make ARCH=openrisc CROSS_COMPILE=or1k-linux-` is this still going to work? -Stafford > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/openrisc/configs/or1ksim_defconfig | 1 - > arch/openrisc/configs/simple_smp_defconfig | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/openrisc/configs/or1ksim_defconfig b/arch/openrisc/configs/or1ksim_defconfig > index d8ff4f8ffb88..75f2da324d0e 100644 > --- a/arch/openrisc/configs/or1ksim_defconfig > +++ b/arch/openrisc/configs/or1ksim_defconfig > @@ -1,4 +1,3 @@ > -CONFIG_CROSS_COMPILE="or1k-linux-" > CONFIG_NO_HZ=y > CONFIG_LOG_BUF_SHIFT=14 > CONFIG_BLK_DEV_INITRD=y > diff --git a/arch/openrisc/configs/simple_smp_defconfig b/arch/openrisc/configs/simple_smp_defconfig > index 64278992df9c..ff49d868e040 100644 > --- a/arch/openrisc/configs/simple_smp_defconfig > +++ b/arch/openrisc/configs/simple_smp_defconfig > @@ -1,4 +1,3 @@ > -CONFIG_CROSS_COMPILE="or1k-linux-" > CONFIG_LOCALVERSION="-simple-smp" > CONFIG_NO_HZ=y > CONFIG_LOG_BUF_SHIFT=14 > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] openrisc: configs: Cleanup CONFIG_CROSS_COMPILE 2020-01-30 21:38 ` Stafford Horne @ 2020-01-31 2:19 ` Masahiro Yamada 2020-01-31 8:25 ` Krzysztof Kozlowski 1 sibling, 0 replies; 4+ messages in thread From: Masahiro Yamada @ 2020-01-31 2:19 UTC (permalink / raw) To: Stafford Horne Cc: Krzysztof Kozlowski, Jonas Bonn, Stefan Kristiansson, Andrew Morton, openrisc, Linux Kernel Mailing List Hi Stafford, On Fri, Jan 31, 2020 at 6:38 AM Stafford Horne <shorne@gmail.com> wrote: > > +cc: Masahiro, > > On Thu, Jan 30, 2020 at 08:19:38PM +0100, Krzysztof Kozlowski wrote: > > CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove > > CONFIG_CROSS_COMPILE support"). > > I see this patch is already in, but does it break 0-day test tools that depend > on this CONFIG_CROSS_COMPILE setup? I guess its been in since 2018, so there > should be no problem. As far as I understand, the 0-day bot passes CROSS_COMPILE= from the command line because I see it in "make.cross" script, which is attached in reports. I did not hear any complaint from 0-day bot maintainers. > Can you also help to update "Documentation/openrisc/openrisc_port.rst"? It > mentions the build steps are: > > Build the Linux kernel as usual:: > > make ARCH=openrisc defconfig > make ARCH=openrisc > > This now changes, I used to use `make ARCH=openrisc CROSS_COMPILE=or1k-linux-` > is this still going to work? Yes, it still works. > -Stafford > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > arch/openrisc/configs/or1ksim_defconfig | 1 - > > arch/openrisc/configs/simple_smp_defconfig | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/arch/openrisc/configs/or1ksim_defconfig b/arch/openrisc/configs/or1ksim_defconfig > > index d8ff4f8ffb88..75f2da324d0e 100644 > > --- a/arch/openrisc/configs/or1ksim_defconfig > > +++ b/arch/openrisc/configs/or1ksim_defconfig > > @@ -1,4 +1,3 @@ > > -CONFIG_CROSS_COMPILE="or1k-linux-" > > CONFIG_NO_HZ=y > > CONFIG_LOG_BUF_SHIFT=14 > > CONFIG_BLK_DEV_INITRD=y > > diff --git a/arch/openrisc/configs/simple_smp_defconfig b/arch/openrisc/configs/simple_smp_defconfig > > index 64278992df9c..ff49d868e040 100644 > > --- a/arch/openrisc/configs/simple_smp_defconfig > > +++ b/arch/openrisc/configs/simple_smp_defconfig > > @@ -1,4 +1,3 @@ > > -CONFIG_CROSS_COMPILE="or1k-linux-" > > CONFIG_LOCALVERSION="-simple-smp" > > CONFIG_NO_HZ=y > > CONFIG_LOG_BUF_SHIFT=14 > > -- > > 2.17.1 > > -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] openrisc: configs: Cleanup CONFIG_CROSS_COMPILE 2020-01-30 21:38 ` Stafford Horne 2020-01-31 2:19 ` Masahiro Yamada @ 2020-01-31 8:25 ` Krzysztof Kozlowski 1 sibling, 0 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2020-01-31 8:25 UTC (permalink / raw) To: Stafford Horne Cc: Jonas Bonn, Stefan Kristiansson, Andrew Morton, openrisc, linux-kernel@vger.kernel.org, yamada.masahiro On Thu, 30 Jan 2020 at 22:38, Stafford Horne <shorne@gmail.com> wrote: > > +cc: Masahiro, > > On Thu, Jan 30, 2020 at 08:19:38PM +0100, Krzysztof Kozlowski wrote: > > CONFIG_CROSS_COMPILE is gone since commit f1089c92da79 ("kbuild: remove > > CONFIG_CROSS_COMPILE support"). > > I see this patch is already in, but does it break 0-day test tools that depend > on this CONFIG_CROSS_COMPILE setup? I guess its been in since 2018, so there > should be no problem. > > Can you also help to update "Documentation/openrisc/openrisc_port.rst"? It > mentions the build steps are: > > Build the Linux kernel as usual:: > > make ARCH=openrisc defconfig > make ARCH=openrisc > > This now changes, I used to use `make ARCH=openrisc CROSS_COMPILE=or1k-linux-` > is this still going to work? All cross compile platforms are being built like this, so I guess openrisc should not be different. I will send a patch for the doc update. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-31 8:25 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-01-30 19:19 [PATCH] openrisc: configs: Cleanup CONFIG_CROSS_COMPILE Krzysztof Kozlowski 2020-01-30 21:38 ` Stafford Horne 2020-01-31 2:19 ` Masahiro Yamada 2020-01-31 8:25 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox