From: Wolfram Sang <wsa@the-dreams.de>
To: Alain Volmat <alain.volmat@st.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
pierre-yves.mordret@st.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabrice.gasnier@st.com
Subject: Re: [PATCH 5/6] i2c: i2c-stm32f7: allow controller to be wakeup-source
Date: Fri, 31 Jan 2020 07:56:55 +0100 [thread overview]
Message-ID: <20200131065654.GB1028@ninjato> (raw)
In-Reply-To: <20200130083927.GH2208@ninjato>
[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]
On Thu, Jan 30, 2020 at 09:39:27AM +0100, Wolfram Sang wrote:
> On Mon, Jan 06, 2020 at 02:28:33PM +0100, Alain Volmat wrote:
> > Allow the i2c-stm32f7 controller to become a wakeup-source
> > of the system. In such case, when a slave is registered to the
> > I2C controller, receiving a I2C message targeting that registered
> > slave address wakes up the suspended system.
> >
> > In order to be able to wake-up, the I2C controller DT node
> > must have the property wakeup-source defined and a slave
> > must be registered.
> >
> > Signed-off-by: Alain Volmat <alain.volmat@st.com>
>
> Applied to for-next, thanks!
And I will drop it again because buildbot rightfully complains:
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/i2c/busses/i2c-stm32f7.c: In function 'stm32f7_i2c_suspend':
> >> drivers/i2c/busses/i2c-stm32f7.c:2199:44: error: 'struct dev_pm_info' has no member named 'wakeup_path'
> if (!device_may_wakeup(dev) && !dev->power.wakeup_path) {
> ^
> drivers/i2c/busses/i2c-stm32f7.c: In function 'stm32f7_i2c_resume':
> drivers/i2c/busses/i2c-stm32f7.c:2218:44: error: 'struct dev_pm_info' has no member named 'wakeup_path'
> if (!device_may_wakeup(dev) && !dev->power.wakeup_path) {
> ^
wakeup_path is only there if CONFIG_PM. Please fix and send a new
version.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-31 6:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 13:28 [PATCH 0/6] i2c-stm32f7: support suspend/resume & wakeup Alain Volmat
2020-01-06 13:28 ` [PATCH 1/6] ARM: dts: stm32: add i2c4 sleep pinctrl on stm32mp15xx-dkx Alain Volmat
2020-01-06 13:28 ` [PATCH 2/6] ARM: dts: stm32: add i2c2/i2c5 sleep pinctrl on stm32mp157c-ev1 Alain Volmat
2020-01-06 13:28 ` [PATCH 3/6] ARM: dts: stm32: add i2c4 sleep pinctrl on stm32mp157c-ed1 Alain Volmat
2020-01-06 13:28 ` [PATCH 4/6] i2c: i2c-stm32f7: add PM_SLEEP suspend/resume support Alain Volmat
2020-01-15 9:13 ` Pierre Yves MORDRET
2020-01-30 8:38 ` Wolfram Sang
2020-01-06 13:28 ` [PATCH 5/6] i2c: i2c-stm32f7: allow controller to be wakeup-source Alain Volmat
2020-01-15 9:13 ` Pierre Yves MORDRET
2020-01-30 8:39 ` Wolfram Sang
2020-01-31 6:56 ` Wolfram Sang [this message]
2020-01-06 13:28 ` [PATCH 6/6] ARM: dts: stm32: add wakeup-source in all I2C nodes of stm32mp157c Alain Volmat
2020-03-13 12:49 ` [PATCH 0/6] i2c-stm32f7: support suspend/resume & wakeup Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131065654.GB1028@ninjato \
--to=wsa@the-dreams.de \
--cc=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox