Re: [PATCH v4 5/6] media: rkvdec: Add the rkvdec driver

Ezequiel Garcia
2020-01-31T11:54:13Z

On Thu, 2020-01-30 at 17:12 +0100, Boris Brezillon wrote:
> On Wed, 29 Jan 2020 16:55:00 -0300
> Ezequiel Garcia <ezequiel@collabora.com> wrote:
>
> > From: Boris Brezillon <boris.brezillon@collabora.com>
> >
> > The rockchip vdec block is a stateless decoder that's able to decode
> > H264, HEVC and VP9 content. This commit adds the core infrastructure
> > and the H264 backend. Support for VP9 and HEVS will be added later on.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> > v4:
> > * Make poc tables const, as suggested by Hans
> > * Move buffer extra space calculation TRY_FMT, as done on Hantro.
> > * Get rid of vb2_request_get_buf and open-code
> > following Cedrus. We can move it to a helper as a follow-up patch.
>
> Well, we know what that means in practice :-).
>

Well, not necesarily. I think we can expect a helper soon,
but it doesn't have to be part of this series :-)

And perhaps we can find another way to link a media request
to a vb2 queue, so we don't have to iterate over objects
like we are doing now?

> > new file mode 100644
> > index 000000000000..1293b3621364
> > --- /dev/null
> > +++ b/drivers/staging/media/rkvdec/rkvdec-regs.h
> > @@ -0,0 +1,239 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Rockchip VPU codec driver
> > + *
> > + * Copyright (C) 2015 Rockchip Electronics Co., Ltd.
> > + * Jung Zhao <jung.zhao@rock-chips.com>
> > + * Alpha Lin <alpha.lin@rock-chips.com>
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + */
>
> Oops, looks like I forgot to remove the license text here. Also not
> entirely sure the copyrights are correct (might be a copy from the
> hantro driver instead of the rkvdec one).
>

Right.

>
> > diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h
> > new file mode 100644
> > index 000000000000..529ef86510d3
> > --- /dev/null
> > +++ b/drivers/staging/media/rkvdec/rkvdec.h
> > @@ -0,0 +1,124 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Hantro VPU codec driver
> > + *
> > + * Copyright 2018 Google LLC.
> > + * Tomasz Figa <tfiga@chromium.org>
> > + *
> > + * Based on s5p-mfc driver by Samsung Electronics Co., Ltd.
> > + * Copyright (C) 2011 Samsung Electronics Co., Ltd.
> > + */
>
> This header has been copied from the hantro driver, so it's most likely
> wrong.
>

Oh, I totally missed this.

Thanks for reviewing!
Ezequiel