Re: [PATCH v4 5/6] media: rkvdec: Add the rkvdec driver

Boris Brezillon
2020-01-31T12:18:52Z

On Fri, 31 Jan 2020 08:53:47 -0300
Ezequiel Garcia <ezequiel@collabora.com> wrote:

> On Thu, 2020-01-30 at 17:12 +0100, Boris Brezillon wrote:
> > On Wed, 29 Jan 2020 16:55:00 -0300
> > Ezequiel Garcia <ezequiel@collabora.com> wrote:
> >
> > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > >
> > > The rockchip vdec block is a stateless decoder that's able to decode
> > > H264, HEVC and VP9 content. This commit adds the core infrastructure
> > > and the H264 backend. Support for VP9 and HEVS will be added later on.

^HEVC

> > >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > > ---
> > > v4:
> > > * Make poc tables const, as suggested by Hans
> > > * Move buffer extra space calculation TRY_FMT, as done on Hantro.
> > > * Get rid of vb2_request_get_buf and open-code
> > > following Cedrus. We can move it to a helper as a follow-up patch.
> >
> > Well, we know what that means in practice :-).
> >
>
> Well, not necesarily. I think we can expect a helper soon,
> but it doesn't have to be part of this series :-)

I'd be happy to be proven wrong ;-).