* [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar
@ 2020-01-23 9:19 Colin King
2020-01-23 12:16 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2020-01-23 9:19 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
linux-iio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a spelling mistake and grammar mistake in a dev_err
message. Fix it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: fix grammar too, thanks to Alexandru Ardelean for spotting this.
---
drivers/iio/dac/ad5755.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index b9175fb4c8ab..1359a1a92fdc 100644
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev)
for_each_child_of_node(np, pp) {
if (devnr >= AD5755_NUM_CHANNELS) {
dev_err(dev,
- "There is to many channels defined in DT\n");
+ "There are too many channels defined in DT\n");
goto error_out;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar
2020-01-23 9:19 [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar Colin King
@ 2020-01-23 12:16 ` Ardelean, Alexandru
2020-02-02 15:53 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2020-01-23 12:16 UTC (permalink / raw)
To: zzzzPopa, zzzzStefan Serban, linux-iio@vger.kernel.org,
jic23@kernel.org, colin.king@canonical.com, Hennerich, Michael,
lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
On Thu, 2020-01-23 at 09:19 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake and grammar mistake in a dev_err
> message. Fix it.
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> V2: fix grammar too, thanks to Alexandru Ardelean for spotting this.
> ---
> drivers/iio/dac/ad5755.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> index b9175fb4c8ab..1359a1a92fdc 100644
> --- a/drivers/iio/dac/ad5755.c
> +++ b/drivers/iio/dac/ad5755.c
> @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct
> device *dev)
> for_each_child_of_node(np, pp) {
> if (devnr >= AD5755_NUM_CHANNELS) {
> dev_err(dev,
> - "There is to many channels defined in DT\n");
> + "There are too many channels defined in DT\n");
> goto error_out;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar
2020-01-23 12:16 ` Ardelean, Alexandru
@ 2020-02-02 15:53 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-02-02 15:53 UTC (permalink / raw)
To: Ardelean, Alexandru
Cc: zzzzPopa, zzzzStefan Serban, linux-iio@vger.kernel.org,
colin.king@canonical.com, Hennerich, Michael, lars@metafoo.de,
knaack.h@gmx.de, pmeerw@pmeerw.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Joe Perches
On Thu, 23 Jan 2020 12:16:03 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Thu, 2020-01-23 at 09:19 +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is a spelling mistake and grammar mistake in a dev_err
> > message. Fix it.
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
This crossed with Joe observing there are quite a few other nice little bits
of janitorial work to be done in this driver.
I merged the two together and fiddled the patch description to cover
the result. Hope no one minds. Seemed like it would save everyone
some time rather than asking for a v3.
Shout out if I've messed it up or you would rather I change the
various tags.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks all,
Jonathan
> > ---
> > V2: fix grammar too, thanks to Alexandru Ardelean for spotting this.
> > ---
> > drivers/iio/dac/ad5755.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> > index b9175fb4c8ab..1359a1a92fdc 100644
> > --- a/drivers/iio/dac/ad5755.c
> > +++ b/drivers/iio/dac/ad5755.c
> > @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct
> > device *dev)
> > for_each_child_of_node(np, pp) {
> > if (devnr >= AD5755_NUM_CHANNELS) {
> > dev_err(dev,
> > - "There is to many channels defined in DT\n");
> > + "There are too many channels defined in DT\n");
> > goto error_out;
> > }
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-02 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-23 9:19 [PATCH][V2] iio: ad5755: fix spelling mistake "to" -> "too" and grammar Colin King
2020-01-23 12:16 ` Ardelean, Alexandru
2020-02-02 15:53 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox