Re: [Intel PMC TGPIO Driver 5/5] drivers/ptp: Add PMC Time-Aware GPIO Driver

Andy Shevchenko
2020-02-07T19:52:58Z

On Fri, Feb 07, 2020 at 09:49:51PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 07, 2020 at 06:28:44PM +0100, Andrew Lunn wrote:
> > On Fri, Feb 07, 2020 at 06:10:46PM +0100, Linus Walleij wrote:
> > > OK this looks like some GPIO registers...
> > >
> > > Then there is a bunch of PTP stuff I don't understand I suppose
> > > related to the precision time protocol.
> >
> > Hi Linus
> >
> > I understand your confusion. The first time this was posted to netdev,
> > i asked it to be renamed because it has very little to do with GPIO
> >
> > https://lore.kernel.org/netdev/20190719132021.GC24930@lunn.ch/
>
> And besides that I didn't see it in internal review list, so, it needs to be
> very carefully reviewed. I already saw some not good formatted and questionable
> code.

Just to have some evidences.

The entire function
static const plat_acpi_resource *find_plat_acpi_resource (struct platform_device *pdev, int *n_pins)
brings a lot of questions.

MODULE_ALIAS("acpi*:INTC1021:*");
What is this?!

And so on...

--
With Best Regards,
Andy Shevchenko