From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] platform/x86: thinkpad_acpi: remove unused defines
Date: Mon, 3 Feb 2020 12:00:43 +0200 [thread overview]
Message-ID: <20200203100043.GZ32742@smile.fi.intel.com> (raw)
In-Reply-To: <20200131143650.4149-2-linux@weissschuh.net>
On Fri, Jan 31, 2020 at 03:36:48PM +0100, Thomas Weißschuh wrote:
> They were never used.
Thanks for the series.
Unfortunately I may not proceed it since it misses our patchwork [1]
for some reason.
Besides that, this patch is okay, but the rest two must be:
- unified together to avoid regression in the middle
- done other way around, simple add aliases to *old* ones
Don't forget to update any documentation if needed.
[1]: https://patchwork.kernel.org/project/platform-driver-x86/list/
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index da794dcfdd92..2d3a99e3efb7 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -9323,9 +9323,6 @@ static struct ibm_struct mute_led_driver_data = {
> #define GET_STOP "BCSG"
> #define SET_STOP "BCSS"
>
> -#define START_ATTR "charge_start_threshold"
> -#define STOP_ATTR "charge_stop_threshold"
> -
> enum {
> BAT_ANY = 0,
> BAT_PRIMARY = 1,
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-03 10:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 20:43 [PATCH 0/3] platform/x86: thinkpad_acpi: use standard charge control attribute names Thomas Weißschuh
2020-01-29 20:43 ` [PATCH 1/3] platform/x86: thinkpad_acpi: remove unused defines Thomas Weißschuh
2020-01-29 20:43 ` [PATCH 2/3] platform/x86: thinkpad_acpi: use standard charge control attribute names Thomas Weißschuh
2020-01-29 20:43 ` [PATCH 3/3] platform/x86: thinkpad_acpi: restore old battery charge attributes Thomas Weißschuh
2020-01-31 14:36 ` [PATCH v2 0/3] platform/x86: thinkpad_acpi: use standard charge control attribute names Thomas Weißschuh
2020-01-31 14:36 ` [PATCH v2 1/3] platform/x86: thinkpad_acpi: remove unused defines Thomas Weißschuh
2020-01-31 14:36 ` [PATCH v2 2/3] platform/x86: thinkpad_acpi: use standard charge control attribute names Thomas Weißschuh
2020-01-31 14:36 ` [PATCH v2 3/3] platform/x86: thinkpad_acpi: restore old battery charge attributes Thomas Weißschuh
2020-02-03 10:00 ` Andy Shevchenko [this message]
2020-02-03 10:02 ` [PATCH v2 1/3] platform/x86: thinkpad_acpi: remove unused defines Andy Shevchenko
2020-02-03 10:04 ` Andy Shevchenko
2020-02-03 12:01 ` [PATCH v3 0/2] platform/x86: thinkpad_acpi: use standard charge control attribute names Thomas Weißschuh
2020-02-03 12:01 ` [PATCH v3 1/2] platform/x86: thinkpad_acpi: remove unused defines Thomas Weißschuh
2020-02-03 12:01 ` [PATCH v3 2/2] platform/x86: thinkpad_acpi: use standard charge control attribute names Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203100043.GZ32742@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox