Re: [PATCH v2 1/3] platform/x86: thinkpad_acpi: remove unused defines

Andy Shevchenko
2020-02-03T10:00:45Z

On Fri, Jan 31, 2020 at 03:36:48PM +0100, Thomas Weißschuh wrote:
> They were never used.

Thanks for the series.

Unfortunately I may not proceed it since it misses our patchwork [1]
for some reason.

Besides that, this patch is okay, but the rest two must be:
- unified together to avoid regression in the middle
- done other way around, simple add aliases to *old* ones

Don't forget to update any documentation if needed.

[1]: https://patchwork.kernel.org/project/platform-driver-x86/list/

>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index da794dcfdd92..2d3a99e3efb7 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -9323,9 +9323,6 @@ static struct ibm_struct mute_led_driver_data = {
> #define GET_STOP "BCSG"
> #define SET_STOP "BCSS"
>
> -#define START_ATTR "charge_start_threshold"
> -#define STOP_ATTR "charge_stop_threshold"
> -
> enum {
> BAT_ANY = 0,
> BAT_PRIMARY = 1,

--
With Best Regards,
Andy Shevchenko