From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBF7C3524D for ; Mon, 3 Feb 2020 14:31:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3E592082E for ; Mon, 3 Feb 2020 14:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbgBCObI (ORCPT ); Mon, 3 Feb 2020 09:31:08 -0500 Received: from mga05.intel.com ([192.55.52.43]:18443 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727649AbgBCObI (ORCPT ); Mon, 3 Feb 2020 09:31:08 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 06:31:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="278756061" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by FMSMGA003.fm.intel.com with ESMTP; 03 Feb 2020 06:31:05 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1iyckk-0007qI-No; Mon, 03 Feb 2020 16:31:06 +0200 Date: Mon, 3 Feb 2020 16:31:06 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Kent Gibson , Linus Walleij , Greg Kroah-Hartman , Guenter Roeck , Geert Uytterhoeven , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 0/3] gpiolib: fix a regression introduced by gpio_do_set_config() Message-ID: <20200203143106.GF32742@smile.fi.intel.com> References: <20200203133026.22930-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200203133026.22930-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 03, 2020 at 02:30:23PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > These three patches fix a regression introduced by commit d90f36851d65 > ("gpiolib: have a single place of calling set_config()"). We first need > to revert patches that came on top of it, then apply the actual fix. Thank you for addressing this! It might be good to add Fixes / Depends-on to the first two, but I didn't look if they are in any of v5.5 or older release. > Bartosz Golaszewski (3): > Revert "gpiolib: Remove duplicated function gpio_do_set_config()" > Revert "gpiolib: remove set but not used variable 'config'" > gpiolib: fix gpio_do_set_config() > > drivers/gpio/gpiolib.c | 31 ++++++++++++++++++++++++++----- > 1 file changed, 26 insertions(+), 5 deletions(-) > > -- > 2.23.0 > -- With Best Regards, Andy Shevchenko