From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA01EC35247 for ; Mon, 3 Feb 2020 18:42:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE22620721 for ; Mon, 3 Feb 2020 18:42:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VXhPfUbv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729682AbgBCSmT (ORCPT ); Mon, 3 Feb 2020 13:42:19 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:42853 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbgBCSmR (ORCPT ); Mon, 3 Feb 2020 13:42:17 -0500 Received: by mail-pl1-f194.google.com with SMTP id e8so3582436plt.9 for ; Mon, 03 Feb 2020 10:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=agwkyBrldDg9XuoJ/vuTI4Bkm2/60ebehPR4ONCSu1A=; b=VXhPfUbvBDPUPwgbLZ+4MxcC+79OxTxus1DagUQ6PZIiK2UHMJjD6BUw6ZUhutRicA AJg5jJl+3QUgunQNplsGHuqurSmnQvgznY5mbYUSue4QpFGXen18JGdddf7mEHTxfT74 jb2o3f8djD5lRy6hUQlrkaUErCqYG4eG6l6u2yvJeVNF7ZtE3ztFOpquhw5qhSzp0CMh PGnyIfgYBh/T42kRWPuPqYwCwZWOHa2r32p6LCLt/5LiT5jZPxsTMltX9yHxR8eQkoRj q5ZLWse95cjzwqVE7EXLBn05/9sO8rDgF+NotlOpDB83qYZK6UK9SudViPpb5uJL19sY b99w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=agwkyBrldDg9XuoJ/vuTI4Bkm2/60ebehPR4ONCSu1A=; b=j1g9RaHFhypfg3+jMD9azKr+OFA0179rOsFk2DDNhEBW3Xk2DmgWHaZiuqzSBur7MD Emd2mZqNItOQckESs52uMyWJM2xDKZCvy7s8seilTyIe/KLHYBLz7MngvcrbsLFYrz85 unshVRNtZkNKrTJd6ORhJAcb5LiT3rcqv2QiKVzT09r6tww+q1sI2/0F2mweWCWxmXet ss1MV8cinpFOfY2YkrR2C68Si5R4MInD8AknpCCxA5HRSgDHXfeN33tsaz56k7uUEd+h BnyjsVI0RR5KHkIpkUOTMs3CBdKwCeDcerst/DQd8Mn/IiNDIh+DX7EGrZdKBpERZHNj gNLw== X-Gm-Message-State: APjAAAXi1TmR2Oftq010+RS9Io/Qg4Y72iKmLIGnGA5stpK5e2vWira7 7vwcpU2iAlCKYk3HhDOpTfjZZw== X-Google-Smtp-Source: APXvYqywujKu1jX+eoX2Ww6KqrPLX4hn6f7F55QKMclqSfe3MX/7rEZ4+VJs8S0YyZQpaUrEQwhQtg== X-Received: by 2002:a17:902:ff08:: with SMTP id f8mr21399303plj.261.1580755336546; Mon, 03 Feb 2020 10:42:16 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id t8sm159330pjy.20.2020.02.03.10.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 10:42:16 -0800 (PST) Date: Mon, 3 Feb 2020 10:42:13 -0800 From: Bjorn Andersson To: Amit Kucheria Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, swboyd@chromium.org, sivaa@codeaurora.org, Andy Gross , Amit Kucheria , linux-pm@vger.kernel.org Subject: Re: [PATCH v4 5/7] drivers: thermal: tsens: Add watchdog support Message-ID: <20200203184213.GG3948@builder> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote: > TSENS IP v2.3 onwards adds support for a watchdog to detect if the TSENS > HW FSM is stuck. Add support to detect and restart the FSM in the > driver. The watchdog is configured by the bootloader, we just enable the > watchdog bark as a debug feature in the kernel. > > Signed-off-by: Amit Kucheria > --- > drivers/thermal/qcom/tsens-common.c | 43 +++++++++++++++++++++++++++++ > drivers/thermal/qcom/tsens-v2.c | 10 +++++++ > drivers/thermal/qcom/tsens.h | 14 ++++++++++ > 3 files changed, 67 insertions(+) > > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c > index 9d1594d2f1ed..ee2414f33606 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -377,6 +377,26 @@ irqreturn_t tsens_critical_irq_thread(int irq, void *data) > struct tsens_irq_data d; > unsigned long flags; > int temp, ret, i; > + u32 wdog_status, wdog_count; > + > + if (priv->feat->has_watchdog) { > + ret = regmap_field_read(priv->rf[WDOG_BARK_STATUS], &wdog_status); > + if (ret) > + return ret; > + > + if (wdog_status) { > + /* Clear WDOG interrupt */ > + regmap_field_write(priv->rf[WDOG_BARK_CLEAR], 1); > + regmap_field_write(priv->rf[WDOG_BARK_CLEAR], 0); > + ret = regmap_field_read(priv->rf[WDOG_BARK_COUNT], &wdog_count); > + if (ret) > + return ret; > + if (wdog_count) > + dev_dbg(priv->dev, "%s: watchdog count: %d\n", __func__, wdog_count); > + > + return IRQ_HANDLED; Patch looks good, but would is make sense to fall through and handle critical interrupts as well (both in positive and error cases of this hunk)? Reviewed-by: Bjorn Andersson Regards, Bjorn