From: Arvind Sankar <nivedita@alum.mit.edu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] initramfs: do not show compression mode choice if INITRAMFS_SOURCE is empty
Date: Mon, 3 Feb 2020 15:06:58 -0500 [thread overview]
Message-ID: <20200203200656.GA455151@rani.riverdale.lan> (raw)
In-Reply-To: <20200203164708.17478-1-masahiroy@kernel.org>
On Tue, Feb 04, 2020 at 01:47:08AM +0900, Masahiro Yamada wrote:
> Since commit ddd09bcc899f ("initramfs: make compression options not
> depend on INITRAMFS_SOURCE"), Kconfig asks the compression mode for
> the built-in initramfs regardless of INITRAMFS_SOURCE.
>
> It is technically simpler, but pointless from a UI perspective,
> Linus says [1].
>
> When INITRAMFS_SOURCE is empty, usr/Makefile creates a tiny default
> cpio, which is so small that nobody cares about the compression.
>
> This commit hides the Kconfig choice in that case. The default cpio
> is embedded without compression, which was the original behavior.
>
> [1]: https://lkml.org/lkml/2020/2/1/160
>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Would it be feasible to check if the kernel is going to be compressed,
i.e. one of the KERNEL_{GZIP,BZIP2,...} options other than
KERNEL_UNCOMPRESSED is set, and default built-in initramfs to
uncompressed in that case as well?
Thanks.
next prev parent reply other threads:[~2020-02-03 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 16:47 [PATCH] initramfs: do not show compression mode choice if INITRAMFS_SOURCE is empty Masahiro Yamada
2020-02-03 17:33 ` Linus Torvalds
2020-02-03 17:35 ` Linus Torvalds
2020-02-06 1:53 ` Masahiro Yamada
2020-02-03 20:06 ` Arvind Sankar [this message]
2020-02-03 21:16 ` [PATCH] initramfs: don't double-compress built-in initramfs if the kernel is compressed Arvind Sankar
2020-02-04 2:22 ` Masahiro Yamada
2020-02-04 16:29 ` Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203200656.GA455151@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=gthelen@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox