From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 291FAC3524D for ; Mon, 3 Feb 2020 23:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F35BA20720 for ; Mon, 3 Feb 2020 23:32:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f11sHAV3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbgBCXcV (ORCPT ); Mon, 3 Feb 2020 18:32:21 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:35862 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726474AbgBCXcU (ORCPT ); Mon, 3 Feb 2020 18:32:20 -0500 Received: by mail-pl1-f194.google.com with SMTP id a6so6465994plm.3 for ; Mon, 03 Feb 2020 15:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bjBRbkXuM7e+Yrzus99X2qOeClLGUq0mOk80jUroNTQ=; b=f11sHAV3jAvM1bXJOrw/YZciwLMyi3wr8lABIITSLW+QDro1s9kpixO7CW7BE4GVsX BVISOC4A3wqtR0ig3nCNQwxS1bCKCdK0Fyk34s/E4BgKiInBGxLTgJeTqoywVTIB/OLR RxrphSseNxUG25/4OUfed2Boef5lf+FvaHdvRkgksQwDCAfwUtz0LOwKQLI9xdMIry5F pwn2wIL5N2oiL18XRU0V0q6dK/U/owXMNzyy6YbGGSxhQbnPqOb9pVCGJHd5Y6wnlrTI Y5UTeiANrjyKMFfce3YrKcKCtSRNC4XS6KBwuswld7HIA1RRWLjiDVG33Yve1wH26Ib9 jT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bjBRbkXuM7e+Yrzus99X2qOeClLGUq0mOk80jUroNTQ=; b=VBRFZfBKiRluddnzjFPQvyiOgf1DZ/KrJvubPK7ICQwVSsq03ui5dS5BsnfMgc/8c+ ydwk6AJ4lyRQZsikG3LcT6oe4Anf8oOhSboryZ8ujqK7K3sLCkFgsmqhd/rTJbh6en/J 6LnooxhLvtegvY7wmQDFa2YWNsPT/f1O6f1rvCF9xiQKoyZQE8yy6ybB59ytNP2kjZvG N235auGE8mxy32KjBEV4yXKmAyI77XMjoTxneWU5HhmaQbOPI7ijvKUKANjobU3kpqnh pI4oDCFT5YF4A4VxJa85cH/eP9tYhCU9+hAVVJUZg1lmvhttceCnqbvFSv8hdq5ZL6EY 65hw== X-Gm-Message-State: APjAAAU/HRhcUoqxyHmMzeiIBfJE6dZtzqY3iV50IawfGlYn3ro5w9RX aW/jEQ9x2ZQ4v24sFbF+jCrdaA== X-Google-Smtp-Source: APXvYqzQD/Xl43wlQXkOagtDcoO4afR50u0nYFhmCaIdIGafU52lJE7MBsFBXcyYsNMf6Wtyriy2iw== X-Received: by 2002:a17:902:bd88:: with SMTP id q8mr24818096pls.13.1580772740218; Mon, 03 Feb 2020 15:32:20 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id e2sm536341pjs.25.2020.02.03.15.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 15:32:19 -0800 (PST) Date: Mon, 3 Feb 2020 15:32:17 -0800 From: Bjorn Andersson To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , robdclark@chromium.org, linux-arm-msm@vger.kernel.org, seanpaul@chromium.org, Jeffrey Hugo , Daniel Vetter , Rob Clark , Jonas Karlman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Jernej Skrabec , Laurent Pinchart Subject: Re: [PATCH v3 2/9] drm/bridge: ti-sn65dsi86: zero is never greater than an unsigned int Message-ID: <20200203233217.GB311651@builder> References: <20191218223530.253106-1-dianders@chromium.org> <20191218143416.v3.2.Id445d0057bedcb0a190009e0706e9254c2fd48eb@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191218143416.v3.2.Id445d0057bedcb0a190009e0706e9254c2fd48eb@changeid> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 18 Dec 14:35 PST 2019, Douglas Anderson wrote: > When we iterate over ti_sn_bridge_dp_rate_lut, there's no reason to > start at index 0 which always contains the value 0. 0 is not a valid > link rate. > > This change should have no real effect but is a small cleanup. > > Signed-off-by: Douglas Anderson > Tested-by: Rob Clark > Reviewed-by: Rob Clark Reviewed-by: Bjorn Andersson > --- > > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 2fb9370a76e6..7b596af265e4 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -458,7 +458,7 @@ static void ti_sn_bridge_set_dp_rate(struct ti_sn_bridge *pdata) > /* set DP data rate */ > dp_rate_mhz = ((bit_rate_mhz / pdata->dsi->lanes) * DP_CLK_FUDGE_NUM) / > DP_CLK_FUDGE_DEN; > - for (i = 0; i < ARRAY_SIZE(ti_sn_bridge_dp_rate_lut) - 1; i++) > + for (i = 1; i < ARRAY_SIZE(ti_sn_bridge_dp_rate_lut) - 1; i++) > if (ti_sn_bridge_dp_rate_lut[i] > dp_rate_mhz) > break; > > -- > 2.24.1.735.g03f4e72817-goog >