From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D349C3524A for ; Tue, 4 Feb 2020 06:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 580562253D for ; Tue, 4 Feb 2020 06:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbgBDGGJ (ORCPT ); Tue, 4 Feb 2020 01:06:09 -0500 Received: from verein.lst.de ([213.95.11.211]:59358 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726552AbgBDGGH (ORCPT ); Tue, 4 Feb 2020 01:06:07 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id DFC7568BFE; Tue, 4 Feb 2020 07:06:04 +0100 (CET) Date: Tue, 4 Feb 2020 07:06:04 +0100 From: Christoph Hellwig To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com, x86@kernel.org, hch@lst.de Subject: Re: [PATCH v2] x86/PCI: ensure to_pci_sysdata usage is available to !CONFIG_PCI Message-ID: <20200204060604.GA31675@lst.de> References: <20200203200942.GA130652@google.com> <20200203215306.172000-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200203215306.172000-1-Jason@zx2c4.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 03, 2020 at 10:53:06PM +0100, Jason A. Donenfeld wrote: > Recently, the helper to_pci_sysdata was added inside of the CONFIG_PCI > guard, but it is used from inside of a CONFIG_NUMA guard, which does not > require CONFIG_PCI. This breaks builds on !CONFIG_PCI machines. This > commit makes that function available in all configurations. > > Signed-off-by: Jason A. Donenfeld > Fixes: aad6aa0cd674 ("x86/PCI: Add to_pci_sysdata() helper") > Cc: Christoph Hellwig Looks good, Reviewed-by: Christoph Hellwig